From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <e@80x24.org>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
git@vger.kernel.org, Paul Tan <pyokagan@gmail.com>
Subject: Re: [PATCH] am: add am.signoff add config variable
Date: Thu, 29 Dec 2016 13:42:13 -0800 [thread overview]
Message-ID: <xmqqtw9m5s5m.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161229084701.GA3643@starla> (Eric Wong's message of "Thu, 29 Dec 2016 08:47:01 +0000")
Eric Wong <e@80x24.org> writes:
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>> git-am has options to enable --message-id and --3way by default,
>> but no option to enable --signoff by default. Add a "am.signoff"
>> config option.
>
> I'm not sure this is a good idea. IANAL, but a sign-off
> has some sort of legal meaning for this project (DCO)
> and that would be better decided on a patch-by-patch basis
> rather than a blanket statement.
IANAL either, but we have been striving to keep output of
$ git grep '\.signoff' Documentation
empty to keep Sign-off meaningful.
Adding more publicized ways to add SoB without thinking will make it
harder to argue against one who tells the court "that log message
ends with a SoB by person X but it is very plausible that it was
done by inertia without person X really intending to certify what
DCO says, and the SoB is meaningless".
> I don't add my SoB to patches (either my own or received) until
> I'm comfortable with it; and I'd rather err on the side of
> forgetting and being prodded to resubmit rather than putting
> an SoB on the wrong patch.
next prev parent reply other threads:[~2016-12-29 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 17:40 [PATCH] am: add am.signoff add config variable Eduardo Habkost
2016-12-28 17:45 ` Stefan Beller
2016-12-28 17:50 ` Eduardo Habkost
2016-12-29 8:47 ` Eric Wong
2016-12-29 15:45 ` Eduardo Habkost
2016-12-29 17:49 ` Jacob Keller
2016-12-29 21:42 ` Junio C Hamano [this message]
2016-12-29 22:16 ` Eduardo Habkost
2016-12-29 22:18 ` Stefan Beller
2016-12-29 22:43 ` Junio C Hamano
2016-12-29 23:34 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtw9m5s5m.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=e@80x24.org \
--cc=ehabkost@redhat.com \
--cc=git@vger.kernel.org \
--cc=pyokagan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).