From: Junio C Hamano <gitster@pobox.com>
To: Richard Hansen <hansenr@google.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] diff: document behavior of relative diff.orderFile
Date: Tue, 10 Jan 2017 14:15:11 -0800 [thread overview]
Message-ID: <xmqqtw96pno0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <9daa70e4-82b0-a82a-67b9-e893546638a7@google.com> (Richard Hansen's message of "Tue, 10 Jan 2017 17:01:22 -0500")
Richard Hansen <hansenr@google.com> writes:
>> A related tangent.
>>
>> I wonder if anything that uses git_config_pathname() should be
>> relative to GIT_DIR when it is not absolute.
>
> I think so. (For bare repositories anyway; non-bare should be
> relative to GIT_WORK_TREE.) Perhaps git_config_pathname() itself
> should convert relative paths to absolute so that every pathname
> setting automatically works without changing any calling code.
Yes, that was what I was alluding to. We might have to wait until
major version boundary to do so, but I think that it is the sensible
way forward in the longer term to convert relative to absolute in
git_config_pathname().
Thanks.
next prev parent reply other threads:[~2017-01-10 22:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 0:40 [PATCH 0/2] minor diff orderfile documentation improvements Richard Hansen
2017-01-10 0:40 ` [PATCH 1/2] diff: document behavior of relative diff.orderFile Richard Hansen
2017-01-10 6:58 ` Jeff King
2017-01-10 17:27 ` Richard Hansen
2017-01-10 20:19 ` Junio C Hamano
2017-01-10 20:23 ` Junio C Hamano
2017-01-10 22:01 ` Richard Hansen
2017-01-10 22:15 ` Junio C Hamano [this message]
2017-01-11 14:41 ` Jeff King
2017-01-11 20:53 ` Junio C Hamano
2017-01-10 0:40 ` [PATCH 2/2] diff: document the pattern format for diff.orderFile Richard Hansen
2017-01-10 20:14 ` Junio C Hamano
2017-01-11 1:14 ` Richard Hansen
2017-01-11 2:46 ` Junio C Hamano
2017-01-11 17:24 ` Richard Hansen
2017-01-11 18:15 ` Junio C Hamano
2017-01-11 18:36 ` Richard Hansen
2017-01-11 21:06 ` Junio C Hamano
2017-01-11 1:57 ` [PATCH v2 0/2] diff orderfile documentation improvements Richard Hansen
2017-01-11 1:57 ` [PATCH v2 1/2] diff: document behavior of relative diff.orderFile Richard Hansen
2017-01-11 1:57 ` [PATCH v2 2/2] diff: document the format of the -O (diff.orderFile) file Richard Hansen
2017-01-15 22:16 ` [PATCH v3 0/2] diff orderfile documentation improvements Richard Hansen
2017-01-15 22:16 ` [PATCH v3 1/2] diff: document behavior of relative diff.orderFile Richard Hansen
2017-01-15 22:16 ` [PATCH v3 2/2] diff: document the format of the -O (diff.orderFile) file Richard Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtw96pno0.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hansenr@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).