From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gpg-interface: Add some output from gpg when it errors out.
Date: Wed, 25 Jan 2017 15:04:38 -0800 [thread overview]
Message-ID: <xmqqtw8m7ncp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170125030434.26448-1-mh@glandium.org> (Mike Hommey's message of "Wed, 25 Jan 2017 12:04:34 +0900")
Mike Hommey <mh@glandium.org> writes:
> For instance, after changing my laptop for a new one, I copied my
> configs, but had some environment differences that broke gpg.
> With this change applied, the output becomes, on this new machine:
> gpg: keyblock resource '/usr/share/keyrings/debian-keyring.gpg': No
> such file or directory
> error: gpg failed to sign the data
> error: unable to sign the tag
>
> which makes it clearer what's wrong.
Overall I think this is a good thing to do. Instead of eating the
status output, showing what we got, especially when we know the
command failed, would make the bug-hunting of user's environment
easier, like you showed above.
The only thing in the design that makes me wonder is the filtering
out based on "[GNUPG:]" prefix. Why do we need to filter them out?
Implementation-wise, I'd be happier if we do not add any new
callsites of strbuf_split(), which is a horrible interface. But
that is a minor detail.
Thanks.
next prev parent reply other threads:[~2017-01-25 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 3:04 [PATCH] gpg-interface: Add some output from gpg when it errors out Mike Hommey
2017-01-25 23:04 ` Junio C Hamano [this message]
2017-01-25 23:54 ` Mike Hommey
2017-01-26 2:37 ` Junio C Hamano
2017-01-26 2:55 ` Mike Hommey
2017-01-26 18:29 ` Junio C Hamano
2017-01-26 5:21 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtw8m7ncp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).