From: Junio C Hamano <firstname.lastname@example.org> To: Stefan Beller <email@example.com> Cc: Ævar Arnfjörð Bjarmason <firstname.lastname@example.org>, "git\@vger.kernel.org" <email@example.com>, Marc Stevens <firstname.lastname@example.org>, Michael Kebe <email@example.com>, Jeff King <firstname.lastname@example.org>, Brandon Williams <email@example.com> Subject: Re: [PATCH v2 0/2] Update sha1dc from upstream & optionally make it a submodule Date: Tue, 23 May 2017 12:22:00 +0900 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAGZ79kb9Ca6QtyRzOW-1Q-E+7Z+PB7+MBtj4KvZx-mV36opWpA@mail.gmail.com> Stefan Beller <email@example.com> writes: > On Mon, May 22, 2017 at 3:27 PM, Junio C Hamano <firstname.lastname@example.org> wrote: >> Ævar Arnfjörð Bjarmason <email@example.com> writes: >> >>> I liked the suggestion to make the URL a relative path, but this would >>> require you to maintain a mirror in the same places you push git.git >>> to, is that something you'd be willing to do? >> >> After thinking about this a bit more, I know what I think we want a >> bit better. >> >> Relative URL (e.g. ../sha1collisiondetection that sits next to the >> copy of git.git) may be a good way to go. I can arrange to create >> necessary repository next to git.git on k.org and github.com but I >> need to double check about other places > > And here we see another deficit with a single URL: > We have to abide by the same scheme at all hosting endpoints. FWIW, I do not see it a deficit. It is a price you may or may not be willing to pay for simplicity, and I think it is a reasonable trade-off. The .gitmodules format can be enhanced to list multiple URLs quite easily. I think the current users all use the equivalent of "git config -f .gitmodules submodule.foo.url" to grab one value. Unless the user chooses to do anything special, they will continue to get the same behaviour whensuch an enhancement happens, which is a good thing. But then, you need to design what users choose to do that is "something special". Should "git clone --recurse-submodules" have a way to control which one of the not-yet-known-before-cloning URLs that may be listed in .gitmodules? Will we have a way to say "For North American users, we recommend this URL, while Asians may want to fetch from this other URL" in .gitmodules and then the recursive clone have a way to say "I want the European option"? Would the recursive clone have a way to go interactive? And from that point of view, "you'll find the submodules relative to the superproject" convention is one way (not necessarily the only way) to allow users not to care too much. The simplicity comes with price and that is perfectly acceptable. Also a single URL scheme may still perfectly fine. .gitmodules may have new submodule.<name>.alternateURL fields and recursive clone can be told to optionally go interactive when such fields are present. Or README can list alternate URLs and instruct the users to use the insteadOf if they want to go to mirrors instead. Those users who do care about picking particular mirror are likely not favor simplicity over flexibility, so they would not likely to do a recursive clone (after all, clone is a single-time operation) and it may be sufficient if they can clone the top-level, read README and then decide how and from where they get their submodules.
next prev parent reply index Thread overview: 20+ messages in thread (expand / mbox.gz / Atom feed / [top]) 2017-05-18 21:28 [PATCH 0/3] " Ævar Arnfjörð Bjarmason 2017-05-18 21:28 ` [PATCH 1/3] sha1dc: update from upstream Ævar Arnfjörð Bjarmason 2017-05-18 21:28 ` [PATCH 2/3] sha1dc: use sha1collisiondetection as a submodule Ævar Arnfjörð Bjarmason 2017-05-20 11:13 ` Junio C Hamano 2017-05-20 11:54 ` [PATCH v2 0/2] Update sha1dc from upstream & optionally make it " Ævar Arnfjörð Bjarmason 2017-05-20 11:54 ` [PATCH v2 1/2] sha1dc: update from upstream Ævar Arnfjörð Bjarmason 2017-05-20 11:54 ` [PATCH v2 2/2] sha1dc: optionally use sha1collisiondetection as a submodule Ævar Arnfjörð Bjarmason 2017-05-22 1:33 ` Junio C Hamano 2017-05-22 2:48 ` Junio C Hamano 2017-05-22 8:27 ` Ævar Arnfjörð Bjarmason 2017-05-22 8:48 ` Junio C Hamano 2017-05-22 22:27 ` [PATCH v2 0/2] Update sha1dc from upstream & optionally make it " Junio C Hamano 2017-05-22 22:48 ` Stefan Beller 2017-05-23 3:22 ` Junio C Hamano [this message] 2017-05-23 10:55 ` Ævar Arnfjörð Bjarmason 2017-05-23 13:06 ` Junio C Hamano 2017-05-25 10:44 ` Ævar Arnfjörð Bjarmason 2017-05-25 23:31 ` Junio C Hamano 2017-05-25 10:47 ` [PATCH 2/3] sha1dc: use sha1collisiondetection as " Ævar Arnfjörð Bjarmason 2017-05-18 21:28 ` [PATCH 3/3] sha1dc: remove the unused sha1dc/ directory Ævar Arnfjörð Bjarmason
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply to all the recipients using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
email@example.com mailing list mirror (one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ or Tor2web: https://www.tor2web.org/ AGPL code for this site: git clone https://public-inbox.org/ public-inbox