From: Junio C Hamano <gitster@pobox.com>
To: Anthony Sottile <asottile@umich.edu>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Fix minor typo in git-diff docs.
Date: Mon, 31 Jul 2017 09:59:32 -0700 [thread overview]
Message-ID: <xmqqtw1silu3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CA+dzEB=cDvp7ZS8x+p+U-5NbK3SNd0FPyj_wP=gvi8mJi6D2ag@mail.gmail.com> (Anthony Sottile's message of "Mon, 31 Jul 2017 07:00:31 -0700")
Anthony Sottile <asottile@umich.edu> writes:
> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index 89cc0f4..43d18a4 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -392,7 +392,7 @@ endif::git-log[]
> the diff between the preimage and `/dev/null`. The resulting patch
> is not meant to be applied with `patch` or `git apply`; this is
> solely for people who want to just concentrate on reviewing the
> - text after the change. In addition, the output obviously lack
> + text after the change. In addition, the output obviously lacks
> enough information to apply such a patch in reverse, even manually,
> hence the name of the option.
> +
Another thing that is more severe. You seem to have replaced all
leading tabs with whitespaces, which makes the patch unusable. For
this single character patch, I can pretend as if I applied your
patch while making the fix myself in my editor, so there is no need
to resend, but please make sure your e-mail client does not do that
the next time.
Thanks. Queued.
next prev parent reply other threads:[~2017-07-31 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 14:00 [PATCH] Fix minor typo in git-diff docs Anthony Sottile
2017-07-31 16:52 ` Junio C Hamano
2017-07-31 16:59 ` Junio C Hamano [this message]
2017-07-31 17:02 ` Anthony Sottile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtw1silu3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=asottile@umich.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).