From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Dridi Boukelmoune <dridi.boukelmoune@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-sh: Avoid sourcing scripts with git --exec-path
Date: Fri, 29 Sep 2017 12:58:38 +0900 [thread overview]
Message-ID: <xmqqtvzmxij5.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170929034856.GB28303@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Thu, 28 Sep 2017 20:48:56 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> This has been broken for a while, but better late than never to
> address it.
I am not sure if this is broken in the first place. We do want to
make sure that the scripted porcelains will source the shell helper
library from matching Git release. The proposed patch goes directly
against that and I do not see how it could be an improvement.
>> --- a/contrib/rerere-train.sh
>> +++ b/contrib/rerere-train.sh
>> @@ -7,7 +7,8 @@ USAGE="$me rev-list-args"
>>
>> SUBDIRECTORY_OK=Yes
>> OPTIONS_SPEC=
>> -. "$(git --exec-path)/git-sh-setup"
>> +PATH="$(git --exec-path):$PATH"
>> +. git-sh-setup
>
> This makes me similarly unhappy about PATH pollution, but it may be
> that there's nothing to be done about that.
To me, all the instances of the unhappiness in your review seem to
be caused by the unjustified declaration that it is bad to source
from the directory "gti --exec-path" reports. If a user wants to
tweak things Git does, why should the user futz with his own copy
of sh-setup and force scripted Porcelains to read from it, which
would only affect the scripted Porcelains and have no chance of
affecting compiled commands? Is building from the source so bad for
an open source tool?
next prev parent reply other threads:[~2017-09-29 3:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 22:31 [PATCH] git-sh: Avoid sourcing scripts with git --exec-path Dridi Boukelmoune
2017-09-29 3:48 ` Jonathan Nieder
2017-09-29 3:58 ` Junio C Hamano [this message]
2017-09-29 4:21 ` Jonathan Nieder
2017-09-29 5:00 ` Junio C Hamano
2017-09-29 11:58 ` Dridi Boukelmoune
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtvzmxij5.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dridi.boukelmoune@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).