From: Junio C Hamano <gitster@pobox.com>
To: Michael Sloan <mgsloan@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Problem with environment of hook execution when git is run with --work-tree / --git-dir
Date: Mon, 27 Nov 2017 10:16:50 +0900 [thread overview]
Message-ID: <xmqqtvxgfrlp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAEDDsWdXQ1+UukvbfRoTPzY3Y9sOaxQ7nh+qL_Mcuy3=XKKh7w@mail.gmail.com> (Michael Sloan's message of "Sat, 25 Nov 2017 23:19:25 -0800")
Michael Sloan <mgsloan@gmail.com> writes:
> So what's the problem with this choice of environment variables?
> Well, the problem is that if PWD is changed during the execution of
> the script, then GIT_WORK_TREE and GIT_DIR will no longer work
> properly. For example, if the pre-commit hook is
>
> #!/bin/sh
> cd some-dir
> git status
>
> This will fail with
>
> Not a git repository: '.dotfiles-git'
That is to be expected. It's up to the script to make them absolute
if it cannot cope with relative paths.
> There is another detail here, which is that when --git-dir /
> --work-tree is not specified, the no GIT_WORK_TREE / GIT_DIR
> environment variable is set. This means that in this case, changing
> PWD in the hook will work fine as long as the search for .git will
> find the right one.
That also is working as designed.
next prev parent reply other threads:[~2017-11-27 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 7:19 Problem with environment of hook execution when git is run with --work-tree / --git-dir Michael Sloan
2017-11-27 1:16 ` Junio C Hamano [this message]
2017-11-27 1:54 ` Michael Sloan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtvxgfrlp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mgsloan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).