From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: suzuki toshiya <mpsuzuki@hiroshima-u.ac.jp>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] git-archive: accept --owner and --group like GNU tar
Date: Fri, 05 Jan 2018 11:10:18 -0800 [thread overview]
Message-ID: <xmqqtvw0ceat.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <ee76246b-579c-fe01-eb9c-d400061b47b6@web.de> ("René Scharfe"'s message of "Fri, 5 Jan 2018 14:54:33 +0100")
René Scharfe <l.s.r@web.de> writes:
>> One practical problem is that users who do this
>>
>> $ git archive HEAD Documentation/ | tar tf -
>>
>> would be expecting (at least) two different things, depending on the
>> situation they are in.
>>
>> So at least you'd need an "--include-untracked" option, I guess.
>
> Right, this breaks down with directories -- most build artifacts (e.g.
> .o files) are probably not meant to end up in archives.
I agree that it is unwise to overload the pathspec for this purpose.
Perhaps bulk of the documentation of a project is in javadoc in its
source code and extracted into some directory, where the user would
want to include untracked things as well as tracked ones, while
untracked contents of other directories are all not meant to be
packaged. As "git archive" is primarily about freezing the contents
of a set of paths in a single revision into an archive, and
including untracked things is secondary, perhaps the right way to do
so would be to:
(1) leave pathspec as-is---they mean "only this area of the named
revision goes into the resulting archive", and
(2) introduce a new "--add-untracked=<wildmatch>" option, that can
be multiply given, is cumulative, and is used to specify which
untracked paths to be included in the result from the working
tree contents.
So
git archive \
--add-untracked=./configure \
--add-untracked='Documentation/**/*.html' \
--add-untracked='Documentation/*.[1-9]' \
HEAD -- . ':!contrib/' ':t/'
might be a way to package up sources we use without tests but
include the built documentation files.
next prev parent reply other threads:[~2018-01-05 19:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 14:05 [PATCH] git-archive: accept --owner and --group like GNU tar suzuki toshiya
2018-01-01 18:29 ` René Scharfe
2018-01-02 0:32 ` Perry Hutchison
2018-01-04 0:43 ` René Scharfe
[not found] ` <df39f62558314cf6a9d9df3e23f31dd8@OS2PR01MB1147.jpnprd01.prod.outlook.com>
2018-01-02 6:58 ` suzuki toshiya
2018-01-02 21:36 ` René Scharfe
[not found] ` <59a1fc058278463996ed68c970a5e08a@OS2PR01MB1147.jpnprd01.prod.outlook.com>
2018-01-04 1:29 ` suzuki toshiya
[not found] ` <955dae095d504b00b3e1c8a956ba852a@OS2PR01MB1147.jpnprd01.prod.outlook.com>
2018-01-04 2:25 ` suzuki toshiya
2018-01-04 16:59 ` René Scharfe
2018-01-04 18:22 ` Junio C Hamano
2018-01-05 13:54 ` René Scharfe
2018-01-05 19:10 ` Junio C Hamano [this message]
[not found] ` <2112f9c245d64f4e89361df7e9de9374@OS2PR01MB1147.jpnprd01.prod.outlook.com>
2018-01-05 4:23 ` suzuki toshiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtvw0ceat.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=mpsuzuki@hiroshima-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).