git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] RelNotes 2.20: drop spurious double quote
Date: Tue, 04 Dec 2018 11:26:21 +0900	[thread overview]
Message-ID: <xmqqtvjuf2nm.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <78f3043b6589f7e3b1872d940ae2ee1315553373.1543868120.git.martin.agren@gmail.com> ("Martin Ågren"'s message of "Mon, 3 Dec 2018 21:21:51 +0100")

Martin Ågren <martin.agren@gmail.com> writes:

> We have three double-quote characters, which is one too many or too few.
> Dropping the last one seems to match the original intention best.

Thanks for spotting.  The actual original intention was that the
user says two things:

	first saying "add only what does not match '*' out of all
	branches" and then saying "add all branches, without any
	exclusion this time".

But letting the user first say one thing and then doing another
thing without saying it is also fine, which is what your version is.



>
> Signed-off-by: Martin Ågren <martin.agren@gmail.com>
> ---
>  Documentation/RelNotes/2.20.0.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/RelNotes/2.20.0.txt b/Documentation/RelNotes/2.20.0.txt
> index 201135d80c..e71fe3dee1 100644
> --- a/Documentation/RelNotes/2.20.0.txt
> +++ b/Documentation/RelNotes/2.20.0.txt
> @@ -578,7 +578,7 @@ Fixes since v2.19
>  
>   * "git rev-parse --exclude=* --branches --branches"  (i.e. first
>     saying "add only things that do not match '*' out of all branches"
> -   and then adding all branches, without any exclusion this time")
> +   and then adding all branches, without any exclusion this time)
>     worked as expected, but "--exclude=* --all --all" did not work the
>     same way, which has been fixed.
>     (merge 5221048092 ag/rev-parse-all-exclude-fix later to maint).

  reply	other threads:[~2018-12-04  2:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-01 14:58 [ANNOUNCE] Git v2.20.0-rc2 Junio C Hamano
2018-12-03 20:21 ` [PATCH 0/3] " Martin Ågren
2018-12-03 20:21   ` [PATCH 1/3] RelNotes 2.20: move some items between sections Martin Ågren
2018-12-04  2:23     ` Junio C Hamano
2018-12-04  5:43       ` Martin Ågren
2018-12-04  5:43         ` [PATCH v2 " Martin Ågren
2018-12-04  5:43         ` [PATCH v2 2/3] RelNotes 2.20: clarify sentence Martin Ågren
2018-12-04  5:43         ` [PATCH v2 3/3] RelNotes 2.20: drop spurious double quote Martin Ågren
2018-12-03 20:21   ` [PATCH 2/3] RelNotes 2.20: clarify sentence Martin Ågren
2018-12-04  2:23     ` Junio C Hamano
2018-12-03 20:21   ` [PATCH 3/3] RelNotes 2.20: drop spurious double quote Martin Ågren
2018-12-04  2:26     ` Junio C Hamano [this message]
2018-12-03 20:45 ` [ANNOUNCE] Git v2.20.0-rc2 Johannes Schindelin
2018-12-04 19:39 ` Ævar Arnfjörð Bjarmason
2018-12-05  2:48   ` Stefan Beller
2018-12-05  4:05     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtvjuf2nm.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).