From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Stan Hu <stanhu@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] sha1-name.c: Fix handling of revisions that contain paths with brackets
Date: Fri, 28 Dec 2018 11:59:46 -0800 [thread overview]
Message-ID: <xmqqtvixo219.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181224080651.GA12708@duynguyen.home> (Duy Nguyen's message of "Mon, 24 Dec 2018 09:06:51 +0100")
Duy Nguyen <pclouds@gmail.com> writes:
> Note that it also shows another corner case we need to be careful
> about: master^{/regex} syntax _can_ contain colons in regex. I suppose
> doing strchr to find the closing '}' here is better than what I did
> below.
Yes, the posted patch breaks master^{/foo:bar}, I suppose.
next prev parent reply other threads:[~2018-12-28 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 23:27 [PATCH] sha1-name.c: Fix handling of revisions that contain paths with brackets Stan Hu
2018-12-23 23:37 ` Stan Hu
2018-12-23 23:40 ` [PATCH v2] " Stan Hu
2018-12-24 8:06 ` Duy Nguyen
2018-12-28 19:59 ` Junio C Hamano [this message]
2018-12-29 5:43 ` [PATCH v3] " Stan Hu
2019-01-02 20:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtvixo219.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=stanhu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).