From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 6B07E1F803 for ; Mon, 7 Jan 2019 17:04:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726601AbfAGREt (ORCPT ); Mon, 7 Jan 2019 12:04:49 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:53484 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726501AbfAGREt (ORCPT ); Mon, 7 Jan 2019 12:04:49 -0500 Received: by mail-wm1-f65.google.com with SMTP id d15so1566313wmb.3 for ; Mon, 07 Jan 2019 09:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NRhg1HLo78JyKn34extpkLyqLLSPtydC48x0ia0vxoQ=; b=KkZvZepWekWyRFZ8E4UI2W0lTXjdfEWH6Cxf2ujM71b3u+/8jD2v4hKWJvuWYfGAtn jAFb1fBtkHuYIeSqrz182BmRXCPAD0eb7jgtnDoO9VXwo6GTL82zCzev1Tj6AKd4Xsha sOkQpricSWzt/usj9vz/SvDmN4/SsZLfZkPKUSAV/Jc1m/hu0LLdlwJ3RA0A8hIUXn6X BZsomhu/r1r/nkOXMjEc8zUgcGIu8zlSkLHZ1zte1JcPSUvQyetz8AH+RifyCj74z0VN UJoRb0jctH1nE62sY5aXokSnMkm/nZxsFNJqiLGdVP5mBI0B+IML50hS0pbT6oj+B3eb cveg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=NRhg1HLo78JyKn34extpkLyqLLSPtydC48x0ia0vxoQ=; b=lnAD8ZuPKfGfvD8NOH7jV45ltZBrDehRfSUBT8cfUknAIOKBII1YW+9VUOj3QwHn2k sgcLp2BIISq5yBu3EglUDg+J0Li+tAF5xfzLZT7veZlkbXsFSIOfAxG7gupKLUp9ws+X AJWwgQ5shubIBqOmlchesBdQE/0xKf5VSNZL4RHxi9qpW+Vzpt4TMS63BPzxuw/NxW37 4Zd8VajIt/XZCW6JVURQ0wM0Bf/wJgbR/XLN/M/FgWsol689+ASOujowithFfG807RGx ojSSpYq/U+Kvx+Bz7egrErJcU8+/PO9RtEy4ZCmIF2riEeH1QTAbzZgjsIG1Bf3zpUui qMsQ== X-Gm-Message-State: AJcUukeS7bPLKH+3OCY0AXWnZvkzYJ2mpgVVNDlsu2wQikctLjYzRhH3 n7NAbaEDRm2t0LN8eGHD00M= X-Google-Smtp-Source: ALg8bN6Ng4hTfhtb4yYNIa9ANjUGDn1AzTY8Oy0fijyFeCu80JO0Zjvg6se8M8tUKsJKEzynEdy05Q== X-Received: by 2002:a1c:7c3:: with SMTP id 186mr9773173wmh.41.1546880687818; Mon, 07 Jan 2019 09:04:47 -0800 (PST) Received: from localhost (168.50.187.35.bc.googleusercontent.com. [35.187.50.168]) by smtp.gmail.com with ESMTPSA id a187sm8702563wmf.33.2019.01.07.09.04.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Jan 2019 09:04:46 -0800 (PST) From: Junio C Hamano To: Thomas Gummerer Cc: Jonathan Nieder , Jeff King , git@vger.kernel.org, Josh Steadmon , Masaya Suzuki Subject: Re: [PATCH] config.mak.dev: add -Wformat References: <20181012184037.15076-1-t.gummerer@gmail.com> <20181012184549.GC4917@sigill.intra.peff.net> <20181012185450.GB52080@aiede.svl.corp.google.com> <20181012191531.GA22611@hank.intra.tgummerer.com> <20181227185900.GE146609@google.com> <20190106181758.GF25639@hank.intra.tgummerer.com> Date: Mon, 07 Jan 2019 09:04:46 -0800 In-Reply-To: <20190106181758.GF25639@hank.intra.tgummerer.com> (Thomas Gummerer's message of "Sun, 6 Jan 2019 18:17:58 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Thomas Gummerer writes: > I agree with the choice of adding -Wall to the CFLAGS here, so even if > it is not added to the CFLAGS generated by autoconf (or in mnually set > up CFLAGS such as in my original case), we still get a complete set of > warnings when DEVELOPER=YesPlease is set. > >> -- >8 -- >> From: Thomas Gummerer >> Date: Fri, 12 Oct 2018 19:40:37 +0100 >> Subject: [PATCH] config.mak.dev: add -Wformat Thanks. I noticed, before merging the topic to 'next', that I needed to retitle this further. I'd use something like this. Subject: config.mak.dev: add -Wall to help autoconf users