From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] Skip ls-refs if possible for HTTP
Date: Thu, 22 Aug 2019 09:27:25 -0700 [thread overview]
Message-ID: <xmqqtva9p3ma.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <cover.1566425828.git.jonathantanmy@google.com> (Jonathan Tan's message of "Wed, 21 Aug 2019 15:20:08 -0700")
Jonathan Tan <jonathantanmy@google.com> writes:
> This was discovered by one of my colleagues when using a partial clone.
> I thought I had resolved the problem with the commits mentioned in patch
> 1 (e70a3030e7 and ancestors), but apparently that is not the case (that
> only worked for native protocols). So here is a fix for HTTP.
>
> I'm not sure of the value of the test in patch 2, but that test does
> fail if I don't update fetch_refs_from_bundle() to first call
> get_refs_from_bundle() if it hasn't already been called.
This probably is totally off-tangent, but do any of these "let's
advertise fewer" changes at the protocol level have to take into
account the use of --prune option on the client side?
> Jonathan Tan (2):
> transport-helper: skip ls-refs if unnecessary
> transport: teach all vtables to allow fetch first
>
> t/t5607-clone-bundle.sh | 11 +++++++++++
> t/t5702-protocol-v2.sh | 13 +++++++++++++
> transport-helper.c | 38 ++++++++++++++++++++++++++++++++------
> transport-internal.h | 6 ------
> transport.c | 18 ++++++------------
> 5 files changed, 62 insertions(+), 24 deletions(-)
next prev parent reply other threads:[~2019-08-22 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 22:20 [PATCH 0/2] Skip ls-refs if possible for HTTP Jonathan Tan
2019-08-21 22:20 ` [PATCH 1/2] transport-helper: skip ls-refs if unnecessary Jonathan Tan
2019-08-21 22:20 ` [PATCH 2/2] transport: teach all vtables to allow fetch first Jonathan Tan
2019-08-22 16:27 ` Junio C Hamano [this message]
2019-08-22 17:23 ` [PATCH 0/2] Skip ls-refs if possible for HTTP Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtva9p3ma.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).