From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] clone: remove fetch_if_missing=0
Date: Wed, 13 Nov 2019 11:50:47 +0900 [thread overview]
Message-ID: <xmqqtv78bibc.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <84d8cee52e7c1dc030826c8caa0e107f80783b9c.1573604516.git.jonathantanmy@google.com> (Jonathan Tan's message of "Tue, 12 Nov 2019 16:34:19 -0800")
Jonathan Tan <jonathantanmy@google.com> writes:
> diff --git a/connected.c b/connected.c
> index 36c4e5dedb..c337f5f7f4 100644
> --- a/connected.c
> +++ b/connected.c
> @@ -62,7 +62,8 @@ int check_connected(oid_iterate_fn fn, void *cb_data,
> * received the objects pointed to by each wanted ref.
> */
> do {
> - if (!repo_has_object_file(the_repository, &oid))
> + if (!repo_has_object_file_with_flags(the_repository, &oid,
> + OBJECT_INFO_SKIP_FETCH_OBJECT))
Wow, good find. Really good find. I guess the exercise to see if
we can get rid of (or at least use less of) the big knob was a good
idea.
Thanks, will queue.
> return 1;
> } while (!fn(cb_data, &oid));
> return 0;
next prev parent reply other threads:[~2019-11-13 2:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 0:34 [PATCH 0/2] More fetch_if_missing=0 removal Jonathan Tan
2019-11-13 0:34 ` [PATCH 1/2] clone: remove fetch_if_missing=0 Jonathan Tan
2019-11-13 2:50 ` Junio C Hamano [this message]
2019-11-13 0:34 ` [PATCH 2/2] promisor-remote: " Jonathan Tan
2019-11-13 2:49 ` [PATCH 0/2] More fetch_if_missing=0 removal Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtv78bibc.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).