From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 308621F487 for ; Sun, 29 Mar 2020 18:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728426AbgC2SgQ (ORCPT ); Sun, 29 Mar 2020 14:36:16 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:63165 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727506AbgC2SgP (ORCPT ); Sun, 29 Mar 2020 14:36:15 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id CBD28C7FDC; Sun, 29 Mar 2020 14:36:13 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=oRFvtMy6Y6ruf0Z1VsiUh2g1bhE=; b=HxKPph xkZLkP22jt+Efib6aaqsERA4WhDozZ16mSHyogkfMDtK6QqhkToDvi4WAgGDJfRW aBN4LTFIncMoxm2uo46zjc/1iYgQyfVyY9ItKg1n5a/EnE5PQ884Hdf4W+D/Ei4e GTynBOAcut0OTTpzkEsxJXGfDVFOcY4j2cHqs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=V6iUWXHYbfBfE98mf+p/Ngn94R6FVCc7 m5UGjamU7t461sHtedS8dLi1qqfy8OUrEu8JO/NjzuSdPiQ5kLwb9RBe1f/6VuI3 ONNPspNEI7l4ez69Amq4ByzXVGJ80fbCTLdDwjtv7xH4pVGVxrodOfFcj0z8YtXg IPx21MkGSn4= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id C351FC7FDA; Sun, 29 Mar 2020 14:36:13 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 10789C7FD9; Sun, 29 Mar 2020 14:36:10 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Garima Singh Cc: Jakub Narebski , Garima Singh via GitGitGadget , git@vger.kernel.org, Derrick Stolee , SZEDER =?utf-8?Q?G=C3=A1bor?= , Jonathan Tan , Jeff Hostetler , Taylor Blau , Jeff King , Christian Couder , Emily Shaffer , Garima Singh Subject: Re: [PATCH v2 00/11] Changed Paths Bloom Filters References: <86a75swuie.fsf@gmail.com> Date: Sun, 29 Mar 2020 11:36:09 -0700 In-Reply-To: (Garima Singh's message of "Fri, 21 Feb 2020 12:41:22 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 29828A34-71EC-11EA-8140-B0405B776F7B-77302942!pb-smtp20.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Garima Singh writes: > On 2/8/2020 6:04 PM, Jakub Narebski wrote: >> "Garima Singh via GitGitGadget" writes: >> ... > I have gone back and forth on doing this. I like most of the core Bloom filter > computations being isolated in one patch/commit. But based on the rest of your > review, it seems like you are leaning heavily on having this split out. > So, I will take a proper stab at doing it for v3. > ... > Thanks for taking the time for reviewing this series so thoroughly! > It is greatly appreciated! Thanks for a great discussion. Just a friendly ping to the thread, so that something from the discussion thread will stay on the first page of mailing list archive's threaded view ;-)