From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 54CFF1F66E for ; Thu, 3 Sep 2020 21:08:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728113AbgICVIw (ORCPT ); Thu, 3 Sep 2020 17:08:52 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:61884 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbgICVIu (ORCPT ); Thu, 3 Sep 2020 17:08:50 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 9CDAA88877; Thu, 3 Sep 2020 17:08:48 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=9C8s3sg4UYxxU0/rOPZT46lQeT8=; b=HD2lgn VgXIs10QMrQRfXxO+N6a6iUscF8sAx3qsOI0C3bTTTCMl6OdEHzWNdOe9GjkwSc4 97E13f8f3Dm0uDo9ppXBLGKIzq6QSj1E2X877HKtKc6OjGzblenJF8UqSRurL/nK vIpK+0rrZho3euw7ZXLhRNkb7WtwKoHkaao4c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=dL8uFMiSUOYSrO+GmPKqgDJvlNvUBl0d 3cZpSo9asaLM7yg24Qlw9EGbiLKLFoYFozUs6OskavYshiRkNwMI9vEgtLh1tEzP V5YyzHIv/5xscHjS4CdMYBZcP+cxA/Q+cXoAYLGj2aO4KFUdTD/8c0s6MaJVDqQc 38LUubgkMYk= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 945E788876; Thu, 3 Sep 2020 17:08:48 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 201A988875; Thu, 3 Sep 2020 17:08:48 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Victor Toni Cc: git@vger.kernel.org, Johannes Schindelin Subject: Re: Aborting git rebase --edit-todo References: Date: Thu, 03 Sep 2020 14:08:47 -0700 In-Reply-To: (Victor Toni's message of "Thu, 3 Sep 2020 21:32:09 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: A8D01A40-EE29-11EA-B66F-2F5D23BA3BAF-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Victor Toni writes: >> I think the implementor chose the first interpretation. The "drop" >> insn is a relatively recent invention, and back when it was missing >> from the vocabulary, I do not think it was possible to say " discard >> all the rest" without emptying the todo list, so that design is >> understandable. >> >> Now we have the "drop" verb, the latter interpretation becomes >> possible without making it impossible for the user to express the >> former. It might be a good idea to >> >> (1) save away the original before allowing --edit-todo to edit, >> >> (2) open the editor, and >> >> (3) when getting an empty buffer back, go back to step (2) using >> the back-up made in step (1). >> >> Either way, the todo list editor buffer can have additional comment >> instructing what happens when the buffer is emptied. >> > Personally I would like to see your approach (1,2,3) implemented > because it is not destructive. If the user wants to achieve something > different he can retry. Obviously I agree that the approach would be nicer than the status quo. It would not be as trivial as a microproject, but would be a good bite-sized starter-task for those aspiring developers who want to dip their toes in the water to start hacking on the codebase ;-)