From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 946A21F4B4 for ; Thu, 17 Sep 2020 21:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726007AbgIQVtk (ORCPT ); Thu, 17 Sep 2020 17:49:40 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:60621 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgIQVtk (ORCPT ); Thu, 17 Sep 2020 17:49:40 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id AFF62F086A; Thu, 17 Sep 2020 17:49:38 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=UFdhnwsxlisXnwkjY3cESR3BnI4=; b=IVMjCR TwYBW6lPPpSU10QQq45JmWoub8sglyoR9J3RVOOLhzes7fA77Ca3C+BBpZNC3vjU GyFjhPuGFTkWAXqPc4wMDyPzUQ7jnoywgHUZIlWG+F1H2t4ajUjBDv/aW4zjGVX/ 59ZMFJKDCr85VG9V2HT9BQXeQxo1OMiIUHsy8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=S837wuUH3QBUjWemGiEhmEFcylfMHyVA UcX42YBMB/PiosrT2sG/+zRny3XbCZStsuLJymJrpQJJ2IMkQiOegbpfJ7grOmG6 78NniSqGmMjZVYffkzL/zsQB2Y4T+Ejf2Ix3MyvxTpYLitAx7DFwWdgT30eD82ty PfAEGjawH1A= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id A8780F0869; Thu, 17 Sep 2020 17:49:38 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id EF6FEF0868; Thu, 17 Sep 2020 17:49:35 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Johannes Schindelin via GitGitGadget" Cc: git@vger.kernel.org, Johannes Schindelin Subject: Re: [PATCH] cmake: ignore generated files References: Date: Thu, 17 Sep 2020 14:49:34 -0700 In-Reply-To: (Johannes Schindelin via GitGitGadget's message of "Thu, 17 Sep 2020 20:37:45 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: ADA03814-F92F-11EA-96E8-843F439F7C89-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > When using CMake to generate the files required to build Git in Visual > Studio, a bunch of files are generated. We will want to prevent them > from being tracked in Git. > > Signed-off-by: Johannes Schindelin > --- > Ignore files generated by CMake > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-735%2Fdscho%2Fignore-generated-cmake-files-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-735/dscho/ignore-generated-cmake-files-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/735 > > .gitignore | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/.gitignore b/.gitignore > index 9673e792db..36f5ac4138 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -239,3 +239,9 @@ Release/ > /git.VC.VC.opendb > /git.VC.db > *.dSYM > +*.vcxproj > +*.vcxproj.filters > +/CMakeCache.txt > +/CMakeFiles/ > +/*.cmake > +/DartConfiguration.tcl Good to catch these cruft. Does the equivalent of "make distclean" need to be updated to clean them as well, or is it sufficient to ignore the build procedure and just rely on "git clean -f -x"?