From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] clean up extern decl of functions
Date: Thu, 08 Oct 2020 19:47:36 -0700 [thread overview]
Message-ID: <xmqqtuv4uncn.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201009015505.GB1314@generichostname> (Denton Liu's message of "Thu, 8 Oct 2020 18:55:05 -0700")
Denton Liu <liu.denton@gmail.com> writes:
> Hi Junio,
>
> On Thu, Oct 08, 2020 at 08:27:55AM -0700, Junio C Hamano wrote:
>> Among external function declarations, somehow only these two
>> functions that return pointer-to-function were declared with
>> "extern" in front.
>>
>> Ideally, we should standardise to _have_ explicit "extern" in front
>> for all function (and data) decls, but let's make things uniform
>> first. Bulk re-addition of extern can be done without any extra
>> difficulty with or without this change.
>
> Why are we re-introducing an explicit "extern"? Since function decls are
> extern by default, what do we gain by doing this?
>
> You mentioned in the past[0]
>
> I think there is a push to drop the "extern " from decls of
> functions in *.h header files.
>
> so are we reversing that push now?
That is certainly on the table. Re-read what you quoted and realize
that I was not expressing my opinion on the "push"; it was just
stating that other reviewers seem to be in favor.
See my other response why I think the "push" was a bad idea.
next prev parent reply other threads:[~2020-10-09 2:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:27 [PATCH] clean up extern decl of functions Junio C Hamano
2020-10-09 1:55 ` Denton Liu
2020-10-09 2:47 ` Junio C Hamano [this message]
2020-10-09 19:26 ` Junio C Hamano
2020-10-09 19:27 ` [RFC] CodingGuidelines: mark external declarations with "extern" Junio C Hamano
2020-10-09 19:57 ` Jeff King
2020-10-09 20:33 ` Junio C Hamano
2020-10-09 23:00 ` Denton Liu
2020-10-09 23:05 ` Junio C Hamano
2020-10-10 0:37 ` Đoàn Trần Công Danh
2020-10-15 1:36 ` Jeff King
2020-10-15 17:15 ` Junio C Hamano
2020-10-15 19:28 ` Jeff King
2020-10-15 19:30 ` [PATCH v2 1/2] usage: define a type for a reporting function Jeff King
2020-10-15 19:30 ` [PATCH v2 2/2] config.mak.dev: build with -fno-common Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtuv4uncn.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).