From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.29.0-rc1
Date: Mon, 26 Oct 2020 11:01:11 -0700 [thread overview]
Message-ID: <xmqqtuugeujc.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <e135ac82-49f1-e06c-45d7-6b3b9f9837c6@web.de> ("René Scharfe"'s message of "Sat, 24 Oct 2020 19:52:49 +0200")
René Scharfe <l.s.r@web.de> writes:
> Am 12.10.20 um 21:19 schrieb René Scharfe:
>> Am 12.10.20 um 18:33 schrieb Junio C Hamano:
>>> If this "feature" were experimental and if the experiment turns out
>>> to be a failure, would we have a viable alternative definition?
>>>
>>> Perhaps "--add-file names an untracked file in the working tree and
>>> the single '--prefix' that is used for entries that come from the
>>> tree object is applied"? Or perhaps remove --add-file entirely as a
>>> failed experiment?
>>
>> Removing --add-file entirely is certainly possible, but it's used in the
>> Makefile now and I can't imagine what would make its disposal necessary.
>>
>> Turning it into a standard OPT_STRING_LIST option for full untracked
>> paths and using the last --prefix value for all archive entries would be
>> a more straightforward UI and might be versatile enough.
>
> Here's how that would have looked, but it seems I'm too late.
I think the "unusual --prefix semantics" does not hurt that much.
If people can play funny games, they can, but if they do not want to
confuse themselves, they can just give a single --prefix at the very
beginning (or no --prefix at all of course), and then the semantics
they will get is the same as what this add-on patch gives, I think.
> The Makefile rules get a bit more fragile because the version files are
> special and the simpler --add-file forces us to create them at their
> actual place if not present, which can lead to problems (stuck version)
> if we don't delete them afterwards. Avoiding that was the reason for
> the more complicated version that ended up in v2.29. That fragility
> could be defused by teaching GIT-VERSION-GEN about version_is_generated.
Thanks for a thoughtful analysis, as usual.
prev parent reply other threads:[~2020-10-26 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:58 [ANNOUNCE] Git v2.29.0-rc1 Junio C Hamano
2020-10-10 16:45 ` René Scharfe
2020-10-11 6:11 ` René Scharfe
2020-10-12 16:35 ` Junio C Hamano
2020-10-12 16:33 ` Junio C Hamano
2020-10-12 19:19 ` René Scharfe
2020-10-24 17:52 ` René Scharfe
2020-10-26 18:01 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtuugeujc.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).