From: Junio C Hamano <gitster@pobox.com>
To: Adam Dinwoodie <adam@dinwoodie.org>
Cc: Matheus Tavares <matheus.bernardino@usp.br>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] apply: don't use core.sharedRepository to create working tree files
Date: Sat, 19 Dec 2020 10:12:56 -0800 [thread overview]
Message-ID: <xmqqtushoeaf.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CA+kUOamDD_SDNLk3sPSwNAojrAAP+g38MjkfG4JMPRTGOVAKAQ@mail.gmail.com> (Adam Dinwoodie's message of "Sat, 19 Dec 2020 17:51:39 +0000")
Adam Dinwoodie <adam@dinwoodie.org> writes:
> Extract from the relevant section of ./t4129-apply-samemode.sh -x
> output, when run with that commit checked out, below:
>
> expecting success of 4129.10 'do not use core.sharedRepository for
> working tree files':
> git reset --hard &&
> test_config core.sharedRepository 0666 &&
> (
> # Remove a default ACL if possible.
> (setfacl -k newdir 2>/dev/null || true) &&
> umask 0077 &&
>
> # Test both files (f1) and leading dirs (d)
> mkdir d &&
> touch f1 d/f2 &&
> git add f1 d/f2 &&
> git diff --staged >patch-f1-and-f2.txt &&
... "point X" (see below) ...
>
> rm -rf d f1 &&
> git apply patch-f1-and-f2.txt &&
>
> echo "-rw-------" >f1_mode.expected &&
> echo "drwx------" >d_mode.expected &&
> test_modebits f1 >f1_mode.actual &&
> test_modebits d >d_mode.actual &&
> test_cmp f1_mode.expected f1_mode.actual &&
> test_cmp d_mode.expected d_mode.actual
> )
> ...
> +++ diff -u f1_mode.expected f1_mode.actual
> --- f1_mode.expected 2020-12-19 16:50:20.169378700 +0000
> +++ f1_mode.actual 2020-12-19 16:50:20.249126000 +0000
> @@ -1 +1 @@
> --rw-------
> +-rw-rw-r--
This tells us that we are getting the umask (set to "me only")
ignored by "git apply".
What would we see in the "t4129-*.sh -x" output if we inserted
ls -ld f1 d d/f2 &&
at "point X" above?
THanks.
next prev parent reply other threads:[~2020-12-19 18:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 15:23 Is git-am expected to honor core.sharedRepository? Matheus Tavares Bernardino
2020-12-01 17:58 ` Junio C Hamano
2020-12-01 23:45 ` [PATCH] apply: don't use core.sharedRepository to create working tree files Matheus Tavares
2020-12-02 0:21 ` Junio C Hamano
2020-12-19 17:51 ` Adam Dinwoodie
2020-12-19 18:12 ` Junio C Hamano [this message]
2020-12-19 18:59 ` Adam Dinwoodie
2020-12-19 18:32 ` Achim Gratz
2020-12-19 19:57 ` Adam Dinwoodie
2020-12-19 21:01 ` Achim Gratz
2020-12-22 22:24 ` Adam Dinwoodie
2020-12-22 22:49 ` Matheus Tavares Bernardino
2020-12-23 11:44 ` [PATCH] t4129: fix setfacl-related permissions failure Adam Dinwoodie
2021-01-09 15:06 ` Matheus Tavares Bernardino
2021-01-09 22:43 ` Junio C Hamano
2020-12-02 22:06 ` Is git-am expected to honor core.sharedRepository? Junio C Hamano
2020-12-03 1:44 ` Matheus Tavares Bernardino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtushoeaf.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).