From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/2] t1450: robustify `remove_object()`
Date: Wed, 10 Feb 2021 12:36:19 -0800 [thread overview]
Message-ID: <xmqqtuqj1wzg.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <24d43d121162a9052f31c760a5fc929fdaad76b5.1612980090.git.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Wed, 10 Feb 2021 18:01:29 +0000")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> -test_expect_success 'setup: helpers for corruption tests' '
> - sha1_file() {
> - remainder=${1#??} &&
> - firsttwo=${1%$remainder} &&
> - echo ".git/objects/$firsttwo/$remainder"
> - } &&
> +sha1_file () {
> + git rev-parse --git-path objects/$(test_oid_to_path "$1")
> +}
Yeah, back when 90cf590f (fsck: optionally show more helpful info
for broken links, 2016-07-17) originally introduced this pattern,
we didn't have nicely abstracted helper, but now we do, and there
is no reason not to use it. Nice.
> - remove_object() {
> - rm "$(sha1_file "$1")"
> - }
> -'
> +remove_object() {
Just like you did for the other one, let's insert SP before () for
consistency here.
> + rm "$(sha1_file "$1")"
> +}
>
> test_expect_success 'object with bad sha1' '
> sha=$(echo blob | git hash-object -w --stdin) &&
Nicely done.
Reviewed-by: Junio C Hamano <gitster@pobox.com>
next prev parent reply other threads:[~2021-02-10 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 18:01 [PATCH 0/2] Fix fsck --name-objects bug Johannes Schindelin via GitGitGadget
2021-02-10 18:01 ` [PATCH 1/2] t1450: robustify `remove_object()` Johannes Schindelin via GitGitGadget
2021-02-10 20:36 ` Junio C Hamano [this message]
2021-02-10 23:20 ` Taylor Blau
2021-02-11 0:10 ` Junio C Hamano
2021-02-10 18:01 ` [PATCH 2/2] fsck --name-objects: be more careful parsing generation numbers Johannes Schindelin via GitGitGadget
2021-02-10 20:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtuqj1wzg.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).