From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 74EE61F5AE for ; Wed, 12 May 2021 03:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230139AbhELD0Z (ORCPT ); Tue, 11 May 2021 23:26:25 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:54060 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230115AbhELD0Z (ORCPT ); Tue, 11 May 2021 23:26:25 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id A0231C878A; Tue, 11 May 2021 23:25:17 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=Me25thdfXpA0ZCEMLbRaus1fYkVF+3AksGTRW8 x8Vig=; b=Sr7t0zB82RxZ/sXoUt6zr4r/UpZAE0FkoUUA0PdqnGToFUq17/yQi8 CR19XOBkHroxE4bxACLfaweZRYHJfEdsn7R4nfFfL1Gs+lxlBnpAn7U2Stku7qS8 cSNPDM/bQbfud+Izh7qAWJ64HTke4/XOQgTjobCltRb+zi7E/d7+U= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 97938C8788; Tue, 11 May 2021 23:25:17 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 179ECC8787; Tue, 11 May 2021 23:25:17 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: Gregory Anders , git@vger.kernel.org Subject: Re: Syntax for specifying a command in git config References: Date: Wed, 12 May 2021 12:25:16 +0900 In-Reply-To: (Jeff King's message of "Tue, 11 May 2021 20:32:40 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: AC2814DC-B2D1-11EB-8B5C-74DE23BA3BAF-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: >> git send-email --smtp-server="/usr/bin/env msmtp" >> git send-email --smtp-server="!my-msa --emulate-sendmail" > > Yes, the patch under discussion does apply to both the command-line > option and the config option (and I agree it should). > > I didn't think about arguments, but you're right that may be a useful > feature. And if done via the shell, as brian suggested elsewhere, would > be more consistent with other parts of Git using "!" syntax. Heh, it was my tongue-in-cheek way to say we do not need this '!' new feature, as long as everybody has 'env' in /usr/bin ;-) > It does make things a little weird in that: > > git send-email --smtp-server='/path/to/my-sendmail foo' > > and > > git send-email --smtp-server '!my-sendmail foo' > > behave differently (the first does not work; it looks for an executable > with a space in the name). True. Hopefully we do not have to worry about $IFS whitespaces in an absolute path to the mail submission program? ... Nah, that's a wishful thinking. But then nobody stops you from saying git send-email --smtp-server '!/path/to/my-sendmail foo' so it probably is OK. We can gradually deprecate the "absolute path" form and standardise on the "!prefix" form.