From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 77AB81F8C6 for ; Mon, 26 Jul 2021 17:34:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235166AbhGZQyA (ORCPT ); Mon, 26 Jul 2021 12:54:00 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:53754 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232234AbhGZQx7 (ORCPT ); Mon, 26 Jul 2021 12:53:59 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id BF8CCCFB8C; Mon, 26 Jul 2021 13:34:27 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=o5FT8KPb+J2HpqYoCYYRbpfAr/HCIPdhrss9Th jPJFA=; b=PhkabZOqBUyG7/LZ8dRC3mLhOwjoXzSJNWT2QNJl7LYwjVNU0HZwLh WgOuhsb43pfbFTO6wOrvFpRNSXVzHXVDR4y0B2LMdGvdE6WEZVNkczOKwZ+IezB5 pxfozlnNT+ILFac8F7mqNdSbE5j818O1+iu5HA3SpfjX8ssaynmHc= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id B5A32CFB8B; Mon, 26 Jul 2021 13:34:27 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.71.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 3CEC4CFB8A; Mon, 26 Jul 2021 13:34:27 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jacob Keller Cc: ZheNing Hu via GitGitGadget , Git mailing list , Christian Couder , Hariom Verma , Bagas Sanjaya , Jeff King , =?utf-8?B?w4Z2YXIg?= =?utf-8?B?QXJuZmrDtnLDsA==?= Bjarmason , Eric Sunshine , Philip Oakley , ZheNing Hu Subject: Re: [PATCH v3 5/5] [GSOC] ref-filter: add %(rest) atom References: <2300b0463f2fca76970ae7debcffa505909b8c4d.1627136062.git.gitgitgadget@gmail.com> Date: Mon, 26 Jul 2021 10:34:26 -0700 In-Reply-To: (Jacob Keller's message of "Sun, 25 Jul 2021 01:29:52 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B9CBEB12-EE37-11EB-A68F-8B3BC6D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jacob Keller writes: > On Sat, Jul 24, 2021 at 7:14 AM ZheNing Hu via GitGitGadget > wrote: >> >> From: ZheNing Hu >> >> %(rest) is a atom used for cat-file batch mode, which can split >> the input lines at the first whitespace boundary, all characters >> before that whitespace are considered to be the object name; >> characters after that first run of whitespace (i.e., the "rest" >> of the line) are output in place of the %(rest) atom. >> >> In order to let "cat-file --batch=%(rest)" use the ref-filter >> interface, add %(rest) atom for ref-filter. >> >> Introduce the reject_atom() to reject the atom %(rest) for >> "git for-each-ref", "git branch", "git tag" and "git verify-tag". >> >> Suggected-by: Jacob Keller >> Mentored-by: Christian Couder >> Mentored-by: Hariom Verma >> Signed-off-by: ZheNing Hu >> --- > > Thanks for the improved commit message here. That helps clarify what > this atom does and aids in understanding the implementation. > > Reviewed-by: Jacob Keller Thanks, both.