From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org, chris.torek@gmail.com,
phillip.wood@dunelm.org.uk, Johannes.Schindelin@gmx.de
Subject: Re: [RFC PATCH 2/3] editor: allow for saving/restoring terminal state
Date: Wed, 01 Dec 2021 22:35:23 -0800 [thread overview]
Message-ID: <xmqqtufrwm38.fsf@gitster.g> (raw)
In-Reply-To: <20211202035446.1154-3-carenas@gmail.com> ("Carlo Marcelo Arenas Belón"'s message of "Wed, 1 Dec 2021 19:54:45 -0800")
Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
> From: Junio C Hamano <gitster@pobox.com>
>
> When EDITOR is invoked to modify a commit message (or do some
> other editing), and it is a terminal mode editor, it will need to
> change the terminal settings, and if it misbehaves could leave the
> terminal output damaged as shown in recent reports from Windows
> Terminal[1]
>
> Instead use the functions provided by compat/terminal to save the
> settings of the terminal and recover safely, but only do so if
> the editor is known to have issues and unless the user has told
> us through a boolean configuration "editor.stty" that it is safe
> not to do so.
>
> [1] https://github.com/microsoft/terminal/issues/9359
> ---
> The commit message was contributed by me, but the rest comes from:
> https://lore.kernel.org/git/xmqq7dcnyh5o.fsf@gitster.g/
> Signed-of-by is missing as I didn't know what would be preferred
> or if the Author will be ok with my grammar (ginger free grammar
> check seems to approve, otherwise)
It was merely an illustration patch, without 3/3 it would not be
complete, and most importantly, finishing the last mile like 3/3 did
is 80% of the work. I'd rather see you take the authorship of the
commit that results from the squashing of 2 and 3.
Any patch I send here is by default signed off by me.
Thanks.
next prev parent reply other threads:[~2021-12-02 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 3:54 [RFC PATCH 0/3] editor: teach it to protect itself from rogue editors Carlo Marcelo Arenas Belón
2021-12-02 3:54 ` [RFC PATCH 1/3] terminal: teach save_term to fail when not foreground Carlo Marcelo Arenas Belón
2021-12-02 3:54 ` [RFC PATCH 2/3] editor: allow for saving/restoring terminal state Carlo Marcelo Arenas Belón
2021-12-02 6:35 ` Junio C Hamano [this message]
2021-12-02 3:54 ` [RFC PATCH 3/3] fixup! " Carlo Marcelo Arenas Belón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtufrwm38.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=carenas@gmail.com \
--cc=chris.torek@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).