From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Jerry Zhang <jerry@skydio.com>, git@vger.kernel.org
Subject: Re: [PATCH V3 1/2] patch-id: Fix antipatterns in tests
Date: Tue, 01 Feb 2022 15:18:13 -0800 [thread overview]
Message-ID: <xmqqtudi9nwq.fsf@gitster.g> (raw)
In-Reply-To: <d9275c31-7558-fc9c-9eb3-2a0cb81a8259@kdbg.org> (Johannes Sixt's message of "Tue, 1 Feb 2022 23:07:31 +0100")
Johannes Sixt <j6t@kdbg.org> writes:
>> + calc_patch_id nonl <nonl &&
>> + calc_patch_id withnl <withnl &&
>
> ... you could in fact just redirect the here-documents into these commands.
That was part of my original suggestion, and then I realized that
nonl and withnl may later be reused and rewrote it before sending my
review comment.
next prev parent reply other threads:[~2022-02-01 23:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 23:23 [PATCH 1/2] format-patch: Fix antipatterns in tests Jerry Zhang
2022-01-31 23:23 ` [PATCH V3 2/2] patch-id: fix scan_hunk_header on diffs with 1 line of before/after Jerry Zhang
2022-01-31 23:52 ` [PATCH V4 " Jerry Zhang
2022-02-02 4:19 ` [PATCH V5 " Jerry Zhang
2022-01-31 23:25 ` [PATCH V2 1/2] patch-id: Fix antipatterns in tests Jerry Zhang
2022-01-31 23:36 ` Junio C Hamano
2022-01-31 23:52 ` [PATCH V3 " Jerry Zhang
2022-02-01 22:07 ` Johannes Sixt
2022-02-01 23:18 ` Junio C Hamano [this message]
2022-02-01 23:16 ` Junio C Hamano
2022-02-02 4:20 ` [PATCH V4 " Jerry Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtudi9nwq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jerry@skydio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).