From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: * X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=1.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 43E7A1F670 for ; Sun, 27 Feb 2022 19:15:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231266AbiB0TPx (ORCPT ); Sun, 27 Feb 2022 14:15:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbiB0TPx (ORCPT ); Sun, 27 Feb 2022 14:15:53 -0500 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 468BB56C2A for ; Sun, 27 Feb 2022 11:15:16 -0800 (PST) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 55DC8F8445; Sun, 27 Feb 2022 14:15:15 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=5SfKe23YpsnuWYrkWEDIvJC6gR+lGL9sSTchg1 UxPr0=; b=WjRyCLVA5FWCqTntVp7T+/De5tfRDtMKjERdnmwh2RKi1a+Hb0HxjP qqvKtjuFeRmvnbU+nB2mjieJRoPDxoLjYzJkAUFyiA2v9bsJTdEdELQXLztpQgFy odfHRRhAQE1JxwAexKVKM0U6cKXjI2G5JMio0ERdUDxGEYKRNcoBU= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 49F62F8442; Sun, 27 Feb 2022 14:15:15 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id B2F28F8441; Sun, 27 Feb 2022 14:15:14 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Abhradeep Chakraborty Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Johannes Schindelin , Eric Sunshine , Julia Lawall , git Subject: Re: [PATCH v4 2/2] parse-options.c: add style checks for usage-strings References: <20220226065704.7137-1-chakrabortyabhradeep79@gmail.com> Date: Sun, 27 Feb 2022 11:15:13 -0800 In-Reply-To: <20220226065704.7137-1-chakrabortyabhradeep79@gmail.com> (Abhradeep Chakraborty's message of "Sat, 26 Feb 2022 12:27:04 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 979A4614-9801-11EC-93DC-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Abhradeep Chakraborty writes: > Junio C Hamano wrote: > >> Let's instead drop [2/2] for now. I do not want us to go back to >> shell script that pretends to know about C language, and I do not >> want to block [1/2] by waiting for a replacement. Fixes in [1/2] >> are pretty much uncontroversial ones that can even be fast-tracked >> down to 'master'. > > Though, as a new contributor, I felt bad about dropping the last > patch, but if you think the last patch request needs more discussion > ( which I think is needed) - I also in favour of dropping the last > commit. > > Would you do this on your side or I will re-submit it with the first > commit? Nah, I can just discard the second commit and keep the first one.