From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 6362A1F54E for ; Wed, 7 Sep 2022 18:13:20 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NnTOn3yV"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230222AbiIGSMQ (ORCPT ); Wed, 7 Sep 2022 14:12:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbiIGSMK (ORCPT ); Wed, 7 Sep 2022 14:12:10 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 536C3C0B55 for ; Wed, 7 Sep 2022 11:12:09 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id i15-20020a17090a4b8f00b0020073b4ac27so8940068pjh.3 for ; Wed, 07 Sep 2022 11:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:subject:cc:to :from:sender:from:to:cc:subject:date; bh=QLL5yn/J6DES0eVkCMJ6H4Gfy1vQYSjbfsLziNGOEi4=; b=NnTOn3yVa5UgXrWi0NNprMB6WNuEHeIH+0/kOLBtUG1HGkqsRrn/UJiAKYccP8u5FZ pgtqE2zi3ue+ywCpgloH0ktKO2osaEO0mS5GoJegueqN+mAHcm78444wa4sG6/9ZaVkH lwm8qJ7vdW/w6FbTxNyruGtBO9K2LvRZyFKrBgD7gupBKRWYIJ8pTLrDjxGuoVdPSTmK CTm0P3Xut3i/EELm9JYFyzwJOTFjbG2qIYxa6O2c9nAhOCxjq7zXiGofByRZiRmnPEVz 3s6WoOi1LzmsODQpNwkjiyODRcC56f2yNiNnTqsJMpcvykhaqKKAPGIePAnQI9LBL+mx ZMRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:subject:cc:to :from:sender:x-gm-message-state:from:to:cc:subject:date; bh=QLL5yn/J6DES0eVkCMJ6H4Gfy1vQYSjbfsLziNGOEi4=; b=0h2mIg0E4fcUB8qAOwAjcGY0uTt0a5DAo2eGneFwaLooxWo6xfT72jdwL9yHHUyYi5 prjXUoMG7O72Tz3LZyiRp1okDXR2M3IpbcLgjig+gOB0My9vBpZi7fNjvTPUZiBF3fo+ vD/w0wSZYMlAXs+HfAe3yjyeUcGZCtAA/9V0GjKzM+DS4zsjHAGlnW6m8LreOC171AMv uFGNr3OEu6CfEOdeoqBYkAFEQEapjFlb6y14AaQIihLXDloeMJrT7v9qI3FdnqAPcLgs WjVu3QFRoxuUk3fOctnLs2G3U7b7fFtCwNcxmgyAvuNUtzoQ1cflIvPVwYtjL75P2K2c pt6Q== X-Gm-Message-State: ACgBeo3gASyOhhjPM7G6ubMpHobDqWfDPFq0tt3sQia81lvZeU+HAAdS 4EBzbba7yXPlBLWWEYKM0qU= X-Google-Smtp-Source: AA6agR6ekwBMr/8gnSs9aNHSgcrpsuEBdcT/wFeBKggaa7NBfe7qKumKe6YhTSoJyZJuD/1/d3LdVw== X-Received: by 2002:a17:902:b484:b0:170:a2d8:80f6 with SMTP id y4-20020a170902b48400b00170a2d880f6mr4938082plr.97.1662574328810; Wed, 07 Sep 2022 11:12:08 -0700 (PDT) Received: from localhost (33.5.83.34.bc.googleusercontent.com. [34.83.5.33]) by smtp.gmail.com with ESMTPSA id 185-20020a6205c2000000b00537daf64e8esm12872932pff.188.2022.09.07.11.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 11:12:08 -0700 (PDT) Sender: Junio C Hamano From: Junio C Hamano To: "Phillip Wood via GitGitGadget" Cc: git@vger.kernel.org, Philippe Blain , Denton Liu , Johannes Schindelin , Phillip Wood , Elijah Newren , Jonathan Tan , Phillip Wood Subject: Re: [PATCH v2 4/7] rebase: rename merge_base to branch_base References: Date: Wed, 07 Sep 2022 11:12:08 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Phillip Wood via GitGitGadget" writes: > From: Phillip Wood > > merge_base is not a very descriptive name, the variable always holds > the merge-base of 'branch' and 'onto' which is commit at the base of > the branch being rebased so rename it to branch_base. OK. Thanks for making the code easier to follow.