[BUG] Non-portable Construct Introduced in diagnose.c (dirent) at v2.38.0-rc0

[BUG] Non-portable Construct Introduced in diagnose.c (dirent) at v2.38.0-rc0

[rsbecker]

The dirent d_type field is not available on every system. This was
introduced at 2.38.0-rc0 in diagnose.c

diagnose.c, line 79: error(1565): struct "dirent" has no field "d_type"

  		    e->d_type == DT_DIR && strlen(e->d_name) == 2 &&

(3 more issues in diagnose exist of this form).

The code should use the  NO_D_TYPE_IN_DIRENT knob to detect whether this is
an existing field as defined in cache.h.

This change breaks the build on NonStop systems (at least). I'm sorry I
missed this during review.

Randall

--
Brief whoami: NonStop&UNIX developer since approximately
UNIX(421664400)
NonStop(211288444200000000)
-- In real life, I talk too much.

Re: [BUG] Non-portable Construct Introduced in diagnose.c (dirent) at v2.38.0-rc0

[Victoria Dye]

rsbecker@nexbridge.com wrote:
> The dirent d_type field is not available on every system. This was
> introduced at 2.38.0-rc0 in diagnose.c
> 
> diagnose.c, line 79: error(1565): struct "dirent" has no field "d_type"
> 
>   		    e->d_type == DT_DIR && strlen(e->d_name) == 2 &&
> 
> (3 more issues in diagnose exist of this form).
> 
> The code should use the  NO_D_TYPE_IN_DIRENT knob to detect whether this is
> an existing field as defined in cache.h.

Apologies for missing that, I'll try to send a patch fixing it either later
today or sometime Monday.

Thanks,
-Victoria

> 
> This change breaks the build on NonStop systems (at least). I'm sorry I
> missed this during review.
> 
> Randall
> 
> --
> Brief whoami: NonStop&UNIX developer since approximately
> UNIX(421664400)
> NonStop(211288444200000000)
> -- In real life, I talk too much.
> 
> 
> 

RE: [BUG] Non-portable Construct Introduced in diagnose.c (dirent) at v2.38.0-rc0

[rsbecker]

On September 16, 2022 7:11 PM, Victoria Dye wrote:
>rsbecker@nexbridge.com wrote:
>> The dirent d_type field is not available on every system. This was
>> introduced at 2.38.0-rc0 in diagnose.c
>>
>> diagnose.c, line 79: error(1565): struct "dirent" has no field "d_type"
>>
>>   		    e->d_type == DT_DIR && strlen(e->d_name) == 2 &&
>>
>> (3 more issues in diagnose exist of this form).
>>
>> The code should use the  NO_D_TYPE_IN_DIRENT knob to detect whether
>> this is an existing field as defined in cache.h.
>
>Apologies for missing that, I'll try to send a patch fixing it either later today or
>sometime Monday.

Thanks. If you need it tested in advance "in the wild", please let me know.

Regards,
Randall

Re: [BUG] Non-portable Construct Introduced in diagnose.c (dirent) at v2.38.0-rc0

[Junio C Hamano]

Victoria Dye <vdye@github.com> writes:

> rsbecker@nexbridge.com wrote:
>> The dirent d_type field is not available on every system. This was
>> introduced at 2.38.0-rc0 in diagnose.c
>> 
>> diagnose.c, line 79: error(1565): struct "dirent" has no field "d_type"
>> 
>>   		    e->d_type == DT_DIR && strlen(e->d_name) == 2 &&
>> 
>> (3 more issues in diagnose exist of this form).
>> 
>> The code should use the  NO_D_TYPE_IN_DIRENT knob to detect whether this is
>> an existing field as defined in cache.h.

Also, even if d_type member exists in the dirent struct, the value
can be DT_UNKNOWN and the code should be prepared to fall back to do
lstat() on the path in such a case.

dir.c::resolve_dtype() can be looked at for inspiration but only for
inspiration and not for copying (because it is about tracked working
tree paths, the function does a lot more than what diagnose.c wants
to).

> Apologies for missing that, I'll try to send a patch fixing it either later
> today or sometime Monday.

Thanks, both of you.