From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id BD2A81F51E for ; Fri, 30 Sep 2022 22:10:19 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="edAY/UJD"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232473AbiI3WKP (ORCPT ); Fri, 30 Sep 2022 18:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232435AbiI3WKF (ORCPT ); Fri, 30 Sep 2022 18:10:05 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 653F43EA69 for ; Fri, 30 Sep 2022 15:10:03 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id A53031BEF0E; Fri, 30 Sep 2022 18:10:02 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=5+B1HexXa8CI q+r9OYhAVPBg6KET6oVWnJZjEFMfMx0=; b=edAY/UJDTwg1QAp+PzGYKU1cR4pC kh6W2zFrb2Ktc34LUaeZAWqUA7I0JYQ0JVUVHuYu6fJED1bWwsx7n+5XFu9sT21H IaCRTTQorjNn9nIkOL5tdkbudRFmujOIE4SKvo0ZnzbwDvgXJCemQ9QCo1l3T4Cr OHV/r2/90pQcYEA= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 9D6021BEF0B; Fri, 30 Sep 2022 18:10:02 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 8321F1BEF06; Fri, 30 Sep 2022 18:09:59 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Victoria Dye , Taylor Blau , Emily Shaffer , Jonathan Nieder , John Cai , Eric Sunshine Subject: Re: [PATCH v3 19/36] doc txt & -h consistency: add or fix optional "--" syntax References: Date: Fri, 30 Sep 2022 15:09:58 -0700 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Fri, 30 Sep 2022 20:07:42 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 9FD8443E-410C-11ED-A627-B31D44D1D7AA-77302942!pb-smtp21.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > diff --git a/builtin/rev-list.c b/builtin/rev-list.c > index ada68a4af5e..3cc8aad52ed 100644 > --- a/builtin/rev-list.c > +++ b/builtin/rev-list.c > @@ -20,7 +20,7 @@ > #include "packfile.h" > =20 > static const char rev_list_usage[] =3D > -"git rev-list [] ... [-- ...]\n" > +"git rev-list [] ... [[--] ...]\n" As rev-list requires at least one commit, so ... means one or more of . Now rev-list does not have to have pathspec, but it is OK to have the double-dash, so git rev-list [] ... [--] [...] would be more correct, no? ... may mean one or more pathspec elements, but having it inside [] makes it zero or more. But it is not a crime to have "--" without any pathspec, yet [[--] ...] requires one or more paths if you want to write "--".