git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v4] am: Allow passing --no-verify flag
Date: Wed, 21 Dec 2022 18:42:44 +0900	[thread overview]
Message-ID: <xmqqtu1prt2j.fsf@gitster.g> (raw)
In-Reply-To: <Y6LP+fCMmP33T6Cx@orome> (Thierry Reding's message of "Wed, 21 Dec 2022 10:20:57 +0100")

Thierry Reding <thierry.reding@gmail.com> writes:

> On Thu, Dec 01, 2022 at 09:55:18AM +0900, Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> > ...
>> > The same comment as the previous one applies to "test_cmp_rev second"
>> > check.  I think removing them would make the tests better.
>> 
>> I will queue this on top for now.  Thanks.
>
> Just to clarify: do you want me to send out another version with your
> changes on top or should I consider this done?

It is up to you.

 * If you agree with the "fix-up" done with the extra commit (marked
   as "SQUASH???") on top and there is no other changes you want to
   make, you can tell me to squash it into your patch.

 * If you don't and have better idea, you can send out an updated
   version, and you have my permission to include any (or all) parts
   of the changes I gave in the message you are responding to.

 * Or if you make a very good argument and convince me why your
   original without my fix-up is better, I may change my mind and
   drop the changes, keeping your original alone.

Of course, folks on the list may have other suggestions and review
comments, which may change the picture again ;-)

In any case, thanks for contributing!


  reply	other threads:[~2022-12-21  9:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 17:28 [PATCH v4] am: Allow passing --no-verify flag Thierry Reding
2022-12-01  0:51 ` Junio C Hamano
2022-12-01  0:55   ` Junio C Hamano
2022-12-21  9:20     ` Thierry Reding
2022-12-21  9:42       ` Junio C Hamano [this message]
2022-12-21 17:21         ` Thierry Reding
2022-12-25 11:26           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtu1prt2j.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).