From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <e@80x24.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] fetch: pass --no-write-fetch-head to subprocesses
Date: Wed, 08 Mar 2023 15:13:19 -0800 [thread overview]
Message-ID: <xmqqttyurg4w.fsf@gitster.g> (raw)
In-Reply-To: <20230308222205.M679514@dcvr> (Eric Wong's message of "Wed, 8 Mar 2023 22:22:05 +0000")
Eric Wong <e@80x24.org> writes:
> +test_expect_success 'git fetch --all --no-write-fetch-head' '
> + (cd test &&
> + rm -f .git/FETCH_HEAD &&
> + git fetch --all --no-write-fetch-head &&
> + test_path_is_missing .git/FETCH_HEAD)
> +'
The style used in the other script might be more modern, but given
that the existing one (in the post context) uses the same older
style, I think that would be OK.
> test_expect_success 'git fetch --all should continue if a remote has errors' '
> (git clone one test2 &&
> cd test2 &&
> diff --git a/t/t5526-fetch-submodules.sh b/t/t5526-fetch-submodules.sh
> index b9546ef8e5..8ffb300f2d 100755
> --- a/t/t5526-fetch-submodules.sh
> +++ b/t/t5526-fetch-submodules.sh
> @@ -167,6 +167,19 @@ test_expect_success "fetch --recurse-submodules recurses into submodules" '
> verify_fetch_result actual.err
> '
>
> +test_expect_success "fetch --recurse-submodules honors --no-write-fetch-head" '
> + (
> + cd downstream &&
> + fh=$(find . -name FETCH_HEAD -type f) &&
> + rm -f $fh &&
I do not like this part. The "rm -f" we saw in the "fetch --all" test
was "make sure it is missing, so that we can be sure that presence
after running 'git fetch' *is* a bug". But using $fh later ...
> + git fetch --recurse-submodules --no-write-fetch-head &&
> + for f in $fh
> + do
> + test_path_is_missing $f || return 1
> + done
... like this means now we depend on FETCH_HEAD being in all
submodule repositories before we start this step.
I think we should instead enumerate submodule repositories, instead
of enumerating existing .git/FETCH_HEAD files.
> + )
> +'
> +
> test_expect_success "submodule.recurse option triggers recursive fetch" '
> add_submodule_commits &&
> (
next prev parent reply other threads:[~2023-03-08 23:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 10:04 [PATCH] fetch: pass --no-write-fetch-head to subprocesses Eric Wong
2023-03-08 17:41 ` Junio C Hamano
2023-03-08 22:22 ` [PATCH v2] " Eric Wong
2023-03-08 23:13 ` Junio C Hamano [this message]
2023-03-08 23:40 ` Junio C Hamano
2023-03-08 23:48 ` Eric Wong
2023-03-09 21:32 ` Junio C Hamano
2023-03-09 3:09 ` [PATCH] " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttyurg4w.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).