From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 6BCF41F428 for ; Wed, 15 Mar 2023 19:14:57 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=LuhapO5f; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232819AbjCOTOx (ORCPT ); Wed, 15 Mar 2023 15:14:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232833AbjCOTOn (ORCPT ); Wed, 15 Mar 2023 15:14:43 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CACB5D24B for ; Wed, 15 Mar 2023 12:14:31 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id iw3so4334220plb.6 for ; Wed, 15 Mar 2023 12:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678907671; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=u/pcqiHewH7t1lcnjQC72BJbjXBz2VgT02FL43f5Gj0=; b=LuhapO5fk/AmoADCgvLLn53yA0r7IAADfiBimlM0cHI+a7/unjP+dF4btfW1HNrv51 KleNIAWNeo5dq48BZIOx1r/CEs5GyzjyoToa/QpohR0k+LTsF+tXtT70c7euOBKLfBDy gKlsT4dCc14D/Yhhnom+MT/uZINSCfhd4BtSJgdwrmqUKtZrdK5IeiKiracbSw9AlqLY bi+DrpA8Exes79eENyTp3toqUrimLjvvQf95g7j8uHmqAPi1DC8cJ27TwXXKLn4cBjBt Uuc1WV3MyyTcbjtIX8bvw+K6M5oU4CFtDKLCng5J2HPCvRJTCO72pobgXuk0g8pV+Ih8 zcNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678907671; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=u/pcqiHewH7t1lcnjQC72BJbjXBz2VgT02FL43f5Gj0=; b=tkZzvAhME4CHVI/8HNZMbBThaC3IIo/75JHM8MFiY60wsI5jkdzJuk6vy9oFxt7RPI H74zGYevVrgg5iEQBoLOzTnx0tXrhWQj5IuHso+65o2nLHsJoJnDRIja61dRuaJ7eFF+ 1xmM5uLDpinGBoiwFjAGMyyEDA1W8LG/BwDhRHCklYb9omiysQeLuYsJSVLHtgaJK5S6 Ef+42BBSXlfUBzX1zeKfe50VyVG3WJ1uqLTQJMtKUxA1h02C564yJXSsDfsnH5g9qfVd gxPlLzQjutfxObPRflklAe0v2ZorKvhgZF035zxplVoxzmZV0W0brrr0PHfBHBenJ04G e4Og== X-Gm-Message-State: AO0yUKWfbSXIvgL+rrUni0e/wqVwYqy5pIkyWZz0JUy2w6NPTVNXgETE fCeSCxkk/7z2Whizl6eYvYM= X-Google-Smtp-Source: AK7set98OQOTcKRRQoe3e0UXUUa99W6fXF2MZC4wd1xng56URmeucVr0DRGTbt30DxvBm1G4msUHBg== X-Received: by 2002:a17:903:230e:b0:1a0:4354:797b with SMTP id d14-20020a170903230e00b001a04354797bmr629138plh.21.1678907670973; Wed, 15 Mar 2023 12:14:30 -0700 (PDT) Received: from localhost (83.92.168.34.bc.googleusercontent.com. [34.168.92.83]) by smtp.gmail.com with ESMTPSA id n5-20020a17090a2bc500b00233bc4edb77sm1723237pje.25.2023.03.15.12.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 12:14:30 -0700 (PDT) Sender: Junio C Hamano From: Junio C Hamano To: Jeff King Cc: Derrick Stolee via GitGitGadget , git@vger.kernel.org, me@ttaylorr.com, vdye@github.com, Phillip Wood , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Derrick Stolee Subject: Re: [PATCH v3 1/8] for-each-ref: add --stdin option References: Date: Wed, 15 Mar 2023 12:14:30 -0700 In-Reply-To: (Jeff King's message of "Wed, 15 Mar 2023 14:06:34 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > On Wed, Mar 15, 2023 at 05:45:36PM +0000, Derrick Stolee via GitGitGadget wrote: > >> @@ -75,7 +79,21 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix) >> ref_sorting_set_sort_flags_all(sorting, REF_SORTING_ICASE, icase); >> filter.ignore_case = icase; >> >> - filter.name_patterns = argv; >> + if (from_stdin) { >> + struct strbuf line = STRBUF_INIT; >> + >> + if (argv[0]) >> + die(_("unknown arguments supplied with --stdin")); >> + >> + while (strbuf_getline(&line, stdin) != EOF) >> + strvec_push(&vec, line.buf); >> + >> + /* vec.v is NULL-terminated, just like 'argv'. */ >> + filter.name_patterns = vec.v; >> + } else { >> + filter.name_patterns = argv; >> + } > > Now that you aren't detaching the "line" strbuf in each iteration of the > loop, it needs to eventually be cleaned up. strbuf_getline() will > _reset() it, which is good, but at the end we'd need a strbuf_release() > or it will leak. Nicely spotted. Thanks.