From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E39941F44D for ; Wed, 28 Feb 2024 18:20:32 +0000 (UTC) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 338F51C25B3A for ; Wed, 28 Feb 2024 18:20:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 476C171EAC; Wed, 28 Feb 2024 18:20:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="yIBrooQ1" Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8473F4084F for ; Wed, 28 Feb 2024 18:20:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.108.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709144407; cv=none; b=VlbvaqHjFj7g3Tv/nt8xT/7XmoCSX9tMPkfpcqcKb8/QRIiFO7vgmKSC5jhTgoxAmo7ABA56p/DcQ5GUbyQ2qlM7mlyjPdU7zzFCSV+LoRhSkMOhUCatLkGbtmsJsedQkxE3AsNqHcKQtt06GQ8hLzSFrm/pJWiYW6441vPiBlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709144407; c=relaxed/simple; bh=NLBfkSv9lof2Mr5x+p0VLeEMuHKFADiaSSPKZCFy2IM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=r8B2ltEAIFRhg7tGaIpaWmMJ4+VbfzGgptnViNeizFtxIgE9xOyxSARi6YVbFFBaytIP0jW82OJp5Wgi5wXNJio6mlV3ISJxcYQLNzYl7G95pSH9niTOTpy+Duj3UJ8iD8lvnssrO9U504poQIuN71o22ftGi7b4JX2yWSUyRAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=yIBrooQ1; arc=none smtp.client-ip=64.147.108.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 820FE1DBC04; Wed, 28 Feb 2024 13:19:59 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=NLBfkSv9lof2Mr5x+p0VLeEMuHKFADiaSSPKZC Fy2IM=; b=yIBrooQ110mwN+j6BJ1AVgOuoyZBbRtaX2mKVNskHeDiLzJe878PAN TG2RAc7ZQoLyGri4tPFGGh/U3zc2pyEIB91DwNeCLyEkPBMmvsmAQ5SvZ2TOY9JA 3Xz/iRPM00c5HZ7TYAmFPOJKsSZABMmmJlvX3+zD9Ipnr5ts8qlXw= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 76CD21DBC03; Wed, 28 Feb 2024 13:19:59 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.176.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id DD93B1DBC02; Wed, 28 Feb 2024 13:19:58 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Sergius Nyah Cc: git@vger.kernel.org, christian.couder@gmail.com, pk@pks.im, shyamthakkar001@gmail.com Subject: Re: [GSOC][PATCH] Userdiff: add builtin patterns for JavaScript. In-Reply-To: <20240228150034.313196-1-sergiusnyah@gmail.com> (Sergius Nyah's message of "Wed, 28 Feb 2024 16:00:34 +0100") References: <20240228150034.313196-1-sergiusnyah@gmail.com> Date: Wed, 28 Feb 2024 10:19:57 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: FB2F1C28-D665-11EE-9EE0-25B3960A682E-77302942!pb-smtp2.pobox.com Sergius Nyah writes: > This commit introduces builtin patterns for JavaScript in userdiff and adds a new test > case in t4018-diff-funcname.sh to verify the enhanced JavaScript function detection in Git diffs. > Signed-off-by: Sergius Justus Chesami Nyah > --- > ...-PATCH-1-2-Add-builtin-patterns-for-.patch | 53 ++++++------------- > t/t4018-diff-funcname.sh | 25 ++++++++- > 2 files changed, 38 insertions(+), 40 deletions(-) You apparently have done "git add" of a file that is a format-patch output, which led to ... > diff --git a/Pattern/0001-Subject-GSOC-RFC-PATCH-1-2-Add-builtin-patterns-for-.patch b/Pattern/0001-Subject-GSOC-RFC-PATCH-1-2-Add-builtin-patterns-for-.patch > index 43593866bc..9c3b80665e 100644 > --- a/Pattern/0001-Subject-GSOC-RFC-PATCH-1-2-Add-builtin-patterns-for-.patch > +++ b/Pattern/0001-Subject-GSOC-RFC-PATCH-1-2-Add-builtin-patterns-for-.patch ... this thing. Wrap the proposed commit log message to a reasonable length and have a blank line before your sign-off. Other pieces of advice about formatting and contents found in Documentation/SubmittingPatches are also helpful. Thanks.