From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.192.0/21 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 29EBE1F44D for ; Tue, 5 Mar 2024 22:26:32 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=JCN3vVDE; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8EDFC1C24E31 for ; Tue, 5 Mar 2024 22:26:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 853EB12D208; Tue, 5 Mar 2024 22:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="JCN3vVDE" Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 018565A796 for ; Tue, 5 Mar 2024 22:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.228.157.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709677578; cv=none; b=STf6oAsVmq8cK2SW9cItL5YdZn2gk06PeeuCq+fdiyUO7MV9wBfWLGJME6i7L5jbWn7KvJXJqcCkAUxiVTRVuKSL2cQEIElX0KysaPjAgLkbiBY8kipkdVcwSwzWehTIOiXuspNs91zc831pJoaAqmBQObFWKJN5dIJSxYdE0Ec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709677578; c=relaxed/simple; bh=fnp3n56u+fsIqjWqPCasQAgGPSC94YMY8RHCYVcqric=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=fHGxpQaWbhiLJO7Njh8FehQHqGd2ITvJ66fQZMkwzM0ZMEQltCFvz//1WQrRTfw4NONpZ7bxVXZKOihANX7w74Yz2T8IpCChkOeCmYwqP+AbnMY9DNTBHT6VgJWvh5xWUes94IQWbzQBZzTVxJFu0fmT/1A2/o8zn6btkAdIAho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=JCN3vVDE; arc=none smtp.client-ip=173.228.157.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 34FD81821B; Tue, 5 Mar 2024 17:26:16 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=fnp3n56u+fsIqjWqPCasQAgGPSC94YMY8RHCYV cqric=; b=JCN3vVDElZO1atrsROsya7+PZA93dx0rWrtZNVnjD6bQf25eaNLMk6 /+h+43CcNWmcFAKfWk6RA8R5DErX0Go/JZlzR4WmJjaqwFtF4rxKRiPVCK7IGrPp 8TkVoo6iz5OZqXwnOHvb5OiQ2UvNQztie2s+VriUuhEVvlLxaT508= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 2D4331821A; Tue, 5 Mar 2024 17:26:16 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.185.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id A728E18219; Tue, 5 Mar 2024 17:26:11 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Beat Bolli" Cc: git@vger.kernel.org, Beat Bolli Subject: Re: [PATCH 03/22] t/lib-cvs.sh: avoid redundant use of cat In-Reply-To: <20240305212533.12947-4-dev+git@drbeat.li> (Beat Bolli's message of "Tue, 5 Mar 2024 22:25:02 +0100") References: <20240305212533.12947-1-dev+git@drbeat.li> <20240305212533.12947-4-dev+git@drbeat.li> Date: Tue, 05 Mar 2024 14:26:10 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 5EEC0BB2-DB3F-11EE-BC92-F515D2CDFF5E-77302942!pb-smtp20.pobox.com "Beat Bolli" writes: > Signed-off-by: Beat Bolli > --- > t/lib-cvs.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/lib-cvs.sh b/t/lib-cvs.sh > index 32b347337908..57b9b2db9b3f 100644 > --- a/t/lib-cvs.sh > +++ b/t/lib-cvs.sh > @@ -71,8 +71,8 @@ test_cmp_branch_tree () { > find . -type d -name .git -prune -o -type f -print > ) | sort >module-git-"$1".list && > test_cmp module-cvs-"$1".list module-git-"$1".list && > - cat module-cvs-"$1".list | while read f > + while read f > do > test_cmp_branch_file "$1" "$f" || return 1 > - done > + done } Again, trivially correct.