From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Mar 2024, #02; Thu, 7)
Date: Fri, 08 Mar 2024 07:42:51 -0800 [thread overview]
Message-ID: <xmqqttlghgqs.fsf@gitster.g> (raw)
In-Reply-To: <f7cd227f-dcde-4d71-b1a6-a4d34c492cd1@gmail.com> (Phillip Wood's message of "Fri, 8 Mar 2024 13:56:35 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
> On 08/03/2024 02:26, Junio C Hamano wrote:
>> * rs/t-ctype-simplify (2024-03-03) 4 commits
>> (merged to 'next' on 2024-03-04 at 9bd84a8877)
>> + t-ctype: avoid duplicating class names
>> + t-ctype: align output of i
>> + t-ctype: simplify EOF check
>> + t-ctype: allow NUL anywhere in the specification string
>> Code simplification to one unit-test program.
>> Will merge to 'master'.
>> source: <20240303101330.20187-1-l.s.r@web.de>
>
> I have some concerns about the last patch of this series
> c.f. <0947cb09-8b07-4fcd-bbe2-ae37c2cd5ec7@gmail.com> It might be too
> late for this series but using the internal implementation functions
> rather than TEST() is not a pattern that I would want us to encourage.
I actually think it is merely showing the lack of necessary features
in TEST() and other public macros/functions of the relatively new
low level test framework. If a user of the framework needs to use
the "internal implementation functions", that gives an incentive to
those who are pushing for the test framework to polish and update it,
so that such a framework client does not have to go deep into the
implementation details. When they come up with an improved framework,
they naturally have the first target to adjust to the framework to
demonstrate that they made the world a better place ;-)
And I think such an update can come after the dust settles in this
case. It is just a single simple test that is isolated and nobody
other than the unit-test folks should care about, as the subject of
test has not seen any change for a long time.
next prev parent reply other threads:[~2024-03-08 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 2:26 What's cooking in git.git (Mar 2024, #02; Thu, 7) Junio C Hamano
2024-03-08 10:31 ` Christian Couder
2024-03-08 15:37 ` Junio C Hamano
2024-03-08 13:56 ` Phillip Wood
2024-03-08 15:42 ` Junio C Hamano [this message]
2024-03-09 11:34 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttlghgqs.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).