From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: David Aguilar <davvid@gmail.com>,
Armin Kunaschik <megabreit@googlemail.com>,
Git List <git@vger.kernel.org>
Subject: Re: t7610-mergetool.sh test failure
Date: Thu, 26 May 2016 23:33:27 -0700 [thread overview]
Message-ID: <xmqqshx4row8.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160527050054.GA25774@sigill.intra.peff.net> (Jeff King's message of "Fri, 27 May 2016 01:00:54 -0400")
Jeff King <peff@peff.net> writes:
> The only one I can think of is that if something leaves cruft in
> $TMPDIR, it could affect later tests that want to `git add`
> indiscriminately.
Or "git ls-files -u", "git clean", etc. I'd mostly worry about a
failed test in which a program dies without a chance to clean up
after itself, and letting the cruft affecting the next test.
> OTOH, I do not think putting things in /tmp is hurting anything. I was
> mostly just surprised by it.
Moving TMPDIR into somewhere under t/ would force us to do more work
to clean things up, and it would probably be a good thing in the
longer term.
I just checked my /tmp, and I see a lot of directories whose name
look like mktemp generated one, with a single socket 's' in them. I
wouldn't be surprised if they turn out to be from our tests that
expect failure, killing a daemon that does not properly clean after
itself. People probably would not notice if they are in /tmp, and
if we moved TMPDIR to the trash, we still wouldn't (because running
tests successfully without "-d" option will remove the trash
directory at the end), but if it were dropped somewhere in the
source tree, we have a better chance of noticing it.
next prev parent reply other threads:[~2016-05-27 6:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 16:44 t7610-mergetool.sh test failure Armin Kunaschik
2016-05-24 16:45 ` Junio C Hamano
2016-05-24 16:53 ` Armin Kunaschik
2016-05-25 23:16 ` Jeff King
2016-05-26 1:51 ` Jeff King
2016-05-27 4:40 ` David Aguilar
2016-05-27 5:00 ` Jeff King
2016-05-27 6:33 ` Junio C Hamano [this message]
2016-05-27 18:24 ` Jeff King
2016-05-27 19:58 ` Junio C Hamano
2016-05-27 20:01 ` Jeff King
2016-06-22 16:53 ` Armin Kunaschik
2016-06-22 17:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshx4row8.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=megabreit@googlemail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).