From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t6300: avoid creating refs/heads/HEAD
Date: Mon, 27 Feb 2017 13:19:29 -0800 [thread overview]
Message-ID: <xmqqshmzuyam.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170227205151.rjhod347ddhmdmxp@sigill.intra.peff.net> (Jeff King's message of "Mon, 27 Feb 2017 15:51:51 -0500")
Jeff King <peff@peff.net> writes:
> I suspect there are a lot of other places that are less clear cut. E.g.,
> I think just:
>
> git branch foo bar
>
> will put "foo" through the same interpretation. So you could do:
>
> git branch -f @{-1} bar
>
> Is that insane? Maybe. But it does work now.
No, it _is_ very sensible, so is "git checkout -B @{-1} <someplace>"
Perhaps interpret-branch-name that does not error out when given "@"
is what is broken? I suspect that calling interpret_empty_at() from
that function is fundamentally flawed. The "@" end user types never
means refs/heads/HEAD, and HEAD@{either reflog or -1} would not mean
anything that should be taken as a branch_name, either.
So perhaps what interpret_empty_at() does is necessary for the "four
capital letters is too many to type, so just type one key while
holding a shift", but it should be called from somewhere else, and
not from interpret_branch_name()?
next prev parent reply other threads:[~2017-02-27 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 9:29 [PATCH] t6300: avoid creating refs/heads/HEAD Jeff King
2017-02-27 19:33 ` Junio C Hamano
2017-02-27 20:51 ` Jeff King
2017-02-27 21:19 ` Junio C Hamano [this message]
2017-02-27 21:41 ` Jeff King
2017-02-27 22:18 ` Junio C Hamano
2017-02-27 21:44 ` Junio C Hamano
2017-02-27 21:46 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshmzuyam.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).