From: Junio C Hamano <gitster@pobox.com> To: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Cc: git@vger.kernel.org, Conrad Irwin <conrad.irwin@gmail.com>, Sitaram Chamarty <sitaramc@gmail.com>, Michael J Gruber <git@drmicha.warpmail.net>, Nguyen Thai Ngoc Duy <pclouds@gmail.com>, Jeff King <peff@peff.net>, Richard Hansen <rhansen@bbn.com>, "Brian M . Carlson" <sandals@crustytoothpaste.net> Subject: Re: [PATCH v3] rev-parse: match @{upstream}, @{u} and @{push} case-insensitively Date: Mon, 27 Mar 2017 10:45:39 -0700 Message-ID: <xmqqshly1um4.fsf@gitster.mtv.corp.google.com> (raw) In-Reply-To: <20170327111655.29941-1-avarab@gmail.com> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > Before this change: > > |----------------+-----+------+-----| > | What? | CI? | CIP? | AG? | > |----------------+-----+------+-----| > | sha1 | Y | - | N | > | describeOutput | N | N | N | > | refname | N | N | N | > | @{<date>} | Y | Y | Y | > | @{<n>} | N/A | N/A | N | > | @{-<n>} | N/A | N/A | N | > | @{upstream} | N | Y | N | > | @{push} | N | Y | N | > | ^{<type>} | N | Y | N | > | ^{/regex} | N | N | N | > |----------------+-----+------+-----| > > After it: > > |----------------+-----+------+-----| > | What? | CI? | CIP? | AG? | > |----------------+-----+------+-----| > | sha1 | Y | - | N | > | describeOutput | N | N | N | > | refname | N | N | N | > | @{<date>} | Y | Y | Y | > | @{<n>} | N/A | N/A | N | > | @{-<n>} | N/A | N/A | N | > | @{upstream} | Y | - | N | > | @{push} | Y | - | N | > | ^{<type>} | N | Y | N | > | ^{/regex} | N | N | N | > |----------------+-----+------+-----| As we are not touching ^{<type>} or ^{/regex}, and it is obvious numbers do not have cases, I'll trim this down to focus only on things that are relevant while queuing: Before this change: |----------------+-----+------+-----| | What? | CI? | CIP? | AG? | |----------------+-----+------+-----| | @{<date>} | Y | Y | Y | | @{upstream} | N | Y | N | | @{push} | N | Y | N | |----------------+-----+------+-----| After it: |----------------+-----+------+-----| | What? | CI? | CIP? | AG? | |----------------+-----+------+-----| | @{<date>} | Y | Y | Y | | @{upstream} | Y | Y | N | | @{push} | Y | Y | N | |----------------+-----+------+-----| should be sufficient to highlight that it was possible to safely make these two things case insensitive, and we made so. For that matter, I do not know the value of AG? field---it only serves to show that @{<approxidate>} is an odd-man out and cannot be used as a good example to follow, but I am too lazy to remove it ;-) > Makes sense, replaced that note with that summary. Here's hopefully a > final v3 with that change. I've omitted the other two patches as noted > in the discussion about those two, I don't think it makes sense to > include them. Thanks. > @@ -122,6 +123,9 @@ refs/remotes/myfork/mybranch > Note in the example that we set up a triangular workflow, where we pull > from one location and push to another. In a non-triangular workflow, > '@\{push}' is the same as '@\{upstream}', and there is no need for it. > ++ > +This suffix is accepted when spelled in uppercase, and means the same > +thing no matter the case. As the above text (including the original) does not explicitly say that lowercase spelling is canonical, the new text is prone to be misinterpreted that only the uppercase version is accepted. I'll do s/is accepted/is also accepted/ while queuing, but please holler if there are better ways to phrase this. Thanks.
next prev parent reply index Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-18 22:34 [PATCH] rev-parse: match @{u}, @{push} and ^{<type>} case-insensitively Ævar Arnfjörð Bjarmason 2017-03-19 9:19 ` Duy Nguyen 2017-03-19 10:04 ` Ævar Arnfjörð Bjarmason 2017-03-19 12:55 ` Junio C Hamano 2017-03-19 14:26 ` Ævar Arnfjörð Bjarmason 2017-03-19 22:53 ` Junio C Hamano 2017-03-26 12:16 ` [PATCH v2 0/3] rev-parse case insensitivity & @{p} synonym Ævar Arnfjörð Bjarmason 2017-03-26 12:16 ` [PATCH v2 1/3] rev-parse: match @{upstream}, @{u} and @{push} case-insensitively Ævar Arnfjörð Bjarmason 2017-03-27 0:27 ` Junio C Hamano 2017-03-27 11:16 ` [PATCH v3] " Ævar Arnfjörð Bjarmason 2017-03-27 17:45 ` Junio C Hamano [this message] 2017-03-27 18:05 ` Ævar Arnfjörð Bjarmason 2017-03-26 12:16 ` [PATCH v2 2/3] rev-parse: add @{p} as a synonym for @{push} Ævar Arnfjörð Bjarmason 2017-03-27 2:53 ` Jeff King 2017-03-27 7:52 ` Ævar Arnfjörð Bjarmason 2017-03-26 12:16 ` [PATCH v2 3/3] rev-parse: match ^{<type>} case-insensitively Ævar Arnfjörð Bjarmason 2017-03-27 0:36 ` Junio C Hamano 2017-03-27 2:58 ` Jeff King 2017-03-27 5:39 ` Junio C Hamano 2017-03-27 7:11 ` Jeff King 2017-03-27 7:33 ` Ævar Arnfjörð Bjarmason 2017-03-21 19:19 ` [PATCH] rev-parse: match @{u}, @{push} and " Ævar Arnfjörð Bjarmason 2017-03-21 19:26 ` Junio C Hamano 2017-03-21 19:43 ` Jeff King
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=xmqqshly1um4.fsf@gitster.mtv.corp.google.com \ --to=gitster@pobox.com \ --cc=avarab@gmail.com \ --cc=conrad.irwin@gmail.com \ --cc=git@drmicha.warpmail.net \ --cc=git@vger.kernel.org \ --cc=pclouds@gmail.com \ --cc=peff@peff.net \ --cc=rhansen@bbn.com \ --cc=sandals@crustytoothpaste.net \ --cc=sitaramc@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org mailing list mirror (one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ or Tor2web: https://www.tor2web.org/ AGPL code for this site: git clone https://public-inbox.org/ public-inbox