From: Junio C Hamano <gitster@pobox.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 0/3] interpret-trailers: add --where, --if-exists, --if-missing
Date: Tue, 25 Jul 2017 14:22:00 -0700 [thread overview]
Message-ID: <xmqqshhktdon.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170724082044.26199-1-bonzini@gnu.org> (Paolo Bonzini's message of "Mon, 24 Jul 2017 10:20:41 +0200")
Paolo Bonzini <bonzini@gnu.org> writes:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> These options are useful to experiment with "git interpret-trailers"
> without having to tinker with .gitconfig (Junio said git should ahve
> done this first and only added configuration afterwards). It can
> be useful in the case where you want a different placement for the trailer,
> or for scripts/aliases that don't want to rely on specific .gitconfig
> settings.
>
> Compared to v2, the main change is that option order on the command-line
> is respected. That is,
>
> --trailer 'acked-by: foo' --where end --trailer 'signed-off-by: me'
>
> will only apply where=end to the second trailer. Likewise,
>
> --where end --trailer 'signed-off-by: me' --no-where \
> --trailer 'acked-by: foo'
>
> will only apply it to the first, reverting to trailer.*.where for the
> "acked-by" trailer.
I am getting the following in my build after merging these to 'pu'.
trailer.c: In function 'apply_arg_if_exists':
trailer.c:270:2: error: enumeration value 'EXISTS_DEFAULT' not handled in switch [-Werror=switch]
switch (arg_tok->conf.if_exists) {
^
trailer.c: In function 'apply_arg_if_missing':
trailer.c:307:2: error: enumeration value 'MISSING_DEFAULT' not handled in switch [-Werror=switch]
switch (arg_tok->conf.if_missing) {
^
trailer.c: In function 'process_command_line_args':
trailer.c:717:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
int separator_pos = find_separator(string, cl_separators);
^
cc1: all warnings being treated as errors
m
prev parent reply other threads:[~2017-07-25 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 8:20 [PATCH v3 0/3] interpret-trailers: add --where, --if-exists, --if-missing Paolo Bonzini
2017-07-24 8:22 ` [PATCH v3 1/3] trailers: export action enums and corresponding lookup functions Paolo Bonzini
2017-07-24 8:22 ` [PATCH v3 2/3] trailers: introduce struct new_trailer_item Paolo Bonzini
2017-07-24 8:22 ` [PATCH v3 3/3] interpret-trailers: add options for actions Paolo Bonzini
2017-07-25 21:22 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshhktdon.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bonzini@gnu.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).