From: Junio C Hamano <firstname.lastname@example.org> To: Stefan Beller <email@example.com> Cc: Jacob Keller <firstname.lastname@example.org>, "git\@vger.kernel.org" <email@example.com> Subject: Re: [PATCH] submodule: correct error message for missing commits. Date: Wed, 26 Jul 2017 14:10:21 -0700 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAGZ79kaYQ5Lzz5i_+uLt3wWtid+YvDxXSyw=isaYj3+98X7Mbg@mail.gmail.com> Stefan Beller <email@example.com> writes: > We _do_ show the submodule as demonstrated by the code sample above > if we possess the objects. > ... >> That sounds like a very sensible and user-centric behaviour to me, >> and "not initialized" sounds like the right message to give in such >> a case (as opposed to "commits not present"---even the user told us >> they are not interesting, we may have them, so "not present" is not >> just incorrect but irrelevant because that is not the reason why we >> are not showing). > > So you are saying we should instead do: > > if (not active) > message = "not initialized" > if (problems with object loading) > message = "commits not present" > ... I think I am. >> Or are you saying that even the user told us that the submodule is >> not interesting, if we had "init" it earlier even once, we show the >> difference and with a wrong label? Showing the difference sounds >> like a bug that is more severe than using a wrong label to me. > > I looked through the man pages and they never specify if submodule > activeness affects the superproject diff, so we'd want to change that > so that only active submodules are diffed. I would think that would match my expectation more closely; if I explicitly told Git to "deinit", and still see the diff to distrat me (i.e. the current behaviour), I would probably feel that it is a bug. I do not know about others who are used to the current beehaviour, though. Do people actively "deinit" a submodule that they once "init"ed, and if so for what purpose? It's not like they want to release the disk resource, so I'd imagine the only reason is to reduce the distracting noise, but I'd prefer to hear from real users rather than speculating. Thanks.
next prev parent reply index Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-26 20:08 Stefan Beller 2017-07-26 20:30 ` Junio C Hamano 2017-07-26 20:56 ` Stefan Beller 2017-07-26 21:10 ` Junio C Hamano [this message] 2017-09-26 18:27 Stefan Beller 2017-09-26 23:37 ` Jacob Keller 2017-09-27 0:52 ` Junio C Hamano
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
email@example.com mailing list mirror (one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ or Tor2web: https://www.tor2web.org/ AGPL code for this site: git clone https://public-inbox.org/ public-inbox