From: Junio C Hamano <gitster@pobox.com>
To: Michael Forney <mforney@mforney.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Drop some dashes from built-in invocations in scripts
Date: Mon, 07 Aug 2017 09:35:55 -0700 [thread overview]
Message-ID: <xmqqshh3qqs4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170805064905.5948-1-mforney@mforney.org> (Michael Forney's message of "Fri, 4 Aug 2017 23:49:05 -0700")
Michael Forney <mforney@mforney.org> writes:
> This way, they still work even if the built-in symlinks aren't
> installed.
>
> Signed-off-by: Michael Forney <mforney@mforney.org>
> ---
> It looks like there was an effort to do this a number of years ago (through
> `make remove-dashes`). These are just a few I noticed were still left in the
> .sh scripts.
Our goal was *not* to have *no* "git-foo" on the filesystem,
though. It happened in v1.6.0 timeframe and it was about removing
"git-foo" from end-user's $PATH.
Earlier there was a more ambitious proposal to remove all "git-foo"
even from $GIT_EXEC_PATH for built-in commands, but that plan was
scuttled [*1*].
The changes in your patch still are good changes to make sure people
who copy & paste code would see fewer instances of "git-foo", but
"will still work even if I break my installation of Git by removing
them from the filesystem" is not the project's goal.
IIUC, you will need "$GIT_EXEC_PATH/git-checkout" on the filesystem
if you want your "git co" alias to work, as we spawn built-in as a
dashed external.
[Reference]
*1* https://public-inbox.org/git/alpine.LFD.1.10.0808261114070.3363@nehalem.linux-foundation.org/
next prev parent reply other threads:[~2017-08-07 16:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-05 6:49 [PATCH] Drop some dashes from built-in invocations in scripts Michael Forney
2017-08-05 22:15 ` Johannes Schindelin
2017-08-05 22:41 ` Junio C Hamano
2017-08-05 22:54 ` Michael Forney
2017-08-05 23:31 ` Junio C Hamano
2017-08-06 5:35 ` Michael Forney
2017-08-07 1:31 ` Junio C Hamano
2017-08-05 23:30 ` Johannes Schindelin
2017-08-07 16:35 ` Junio C Hamano [this message]
2017-08-07 17:12 ` Junio C Hamano
2017-08-07 17:58 ` Michael Forney
2017-08-07 18:18 ` Junio C Hamano
2017-08-07 19:22 ` Johannes Schindelin
2017-08-07 19:48 ` Junio C Hamano
2017-08-07 21:07 ` Johannes Schindelin
2017-08-07 21:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshh3qqs4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mforney@mforney.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).