From: Junio C Hamano <firstname.lastname@example.org> To: Phillip Wood <email@example.com> Cc: Git Mailing List <firstname.lastname@example.org>, Gustavo Leite <email@example.com>, Phillip Wood <firstname.lastname@example.org> Subject: Re: [PATCH v2 2/3] add -p: allow line selection to be inverted Date: Tue, 13 Mar 2018 09:32:08 -0700 Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Phillip Wood <email@example.com> writes: > On 08/03/18 17:53, Junio C Hamano wrote: >> Phillip Wood <firstname.lastname@example.org> writes: >> >>> and use a leading '-' for inversion. I'm tempted to keep supporting 'n-' >>> to mean everything from 'n' to the last line though. >> >> Thanks for double checking. It would be a better endgame to follow >> up with an update to existing "range selection" code to also support >> "n-", if you go that route. >> > I'm afraid I'm not sure exactly what you're suggesting. At the moment > the range selection code is in the first patch and supports incomplete > ranges. Are you suggesting that support for incomplete ranges should be > in a separate patch or have I misunderstood? My observation of the situation behind my reasoning is: - There is an existing UI that uses "-X" to mean "exclude what matches X" and that was the reason why you decided to follow suit instead of using "^X" for inversion of X. - Such an existing UI would not have used "-X" to mean "the first possible choice thru X". You will lose that from your new thing and you accepted that. - It is likely (I did not check, though) that the existing UI would not have used "Y-" to mean "starting from Y all the possible choices thru to the end", but that is merely for symmetry with the lack (inability to use) of "-X". There is no fundamental reason why "Y-" cannot mean that, and you are tempted to allow do so in your new thing for the same reason. So if we are going to have "N-" to mean "everything from N to the last line", then the same "Starting at N to the end of the all the possible choices" should be allowed in the existing UI (i.e. the one that forced you to give up "^X" for the sake of consistency) for the same consistency reasons, no? For that, if you want to keep the "n-" you did in your first patch, the most logical thing is to have a preparatory enhancement to teach "N-" to list_and_choose(), and then build your series on top. Or you can do without such a change to list_and_choose() in your series, in which case, you drop "n-" support and then at the very end after the series settles, add "n-" support to the new code in this series and to list_and_choose() at the same time in a follow-up patch.
next prev parent reply index Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-19 11:36 [PATCH v1 0/3] add -p: select individual hunk lines Phillip Wood 2018-02-19 11:36 ` [PATCH v1 2/3] add -p: allow line selection to be inverted Phillip Wood 2018-02-19 11:36 ` [PATCH v1 3/3] add -p: optimize line selection for short hunks Phillip Wood 2018-02-19 12:20 ` [PATCH v1 0/3] add -p: select individual hunk lines Gustavo Leite 2018-03-06 10:17 ` [PATCH v2 " Phillip Wood 2018-03-06 10:17 ` [PATCH v2 1/3] " Phillip Wood 2018-03-06 20:29 ` Igor Djordjevic 2018-03-06 21:33 ` Igor Djordjevic 2018-03-06 10:17 ` [PATCH v2 2/3] add -p: allow line selection to be inverted Phillip Wood 2018-03-06 19:57 ` Junio C Hamano 2018-03-08 11:05 ` Phillip Wood 2018-03-08 17:53 ` Junio C Hamano 2018-03-13 12:06 ` Phillip Wood 2018-03-13 16:32 ` Junio C Hamano [this message] 2018-03-14 11:02 ` Phillip Wood 2018-03-06 20:41 ` Igor Djordjevic 2018-03-06 10:17 ` [PATCH v2 3/3] add -p: optimize line selection for short hunks Phillip Wood 2018-03-06 20:33 ` Igor Djordjevic 2018-03-06 20:19 ` [PATCH v2 0/3] add -p: select individual hunk lines Igor Djordjevic 2018-03-06 21:03 ` Junio C Hamano 2018-03-06 21:20 ` Igor Djordjevic 2018-03-16 10:13 ` [PATCH v3 " Phillip Wood 2018-03-16 10:13 ` [PATCH v3 1/3] " Phillip Wood 2018-03-16 10:13 ` [PATCH v3 2/3] add -p: allow line selection to be inverted Phillip Wood 2018-03-16 10:13 ` [PATCH v3 3/3] add -p: optimize line selection for short hunks Phillip Wood 2018-03-29 18:32 ` [PATCH v3 0/3] add -p: select individual hunk lines Junio C Hamano 2018-03-30 11:09 ` Phillip Wood 2018-03-31 19:20 ` Ævar Arnfjörð Bjarmason 2018-04-02 10:55 ` Phillip Wood 2018-04-02 11:39 ` Ævar Arnfjörð Bjarmason
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
email@example.com mailing list mirror (one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ or Tor2web: https://www.tor2web.org/ AGPL code for this site: git clone https://public-inbox.org/ public-inbox