From: Junio C Hamano <gitster@pobox.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: sunshine@sunshineco.com, jrn@google.com, git@vger.kernel.org
Subject: Re: [PATCH v5 1/2] config: document git config getter return value
Date: Mon, 06 Aug 2018 09:32:34 -0700 [thread overview]
Message-ID: <xmqqsh3rpial.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180806143313.104495-2-hanwen@google.com> (Han-Wen Nienhuys's message of "Mon, 6 Aug 2018 16:33:12 +0200")
Han-Wen Nienhuys <hanwen@google.com> writes:
> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
> ---
> config.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
I think this is good (I read all the comments on v3 and v4 in the
archive before I said this). Let's split it off from the other
patch and queue it on its own merit (not that I think the other one
is not yet good enough---I haven't even looked at it yet ;-).
Thanks.
>
> diff --git a/config.h b/config.h
> index bb2f506b27..183b31ebf4 100644
> --- a/config.h
> +++ b/config.h
> @@ -188,9 +188,14 @@ struct config_set {
>
> extern void git_configset_init(struct config_set *cs);
> extern int git_configset_add_file(struct config_set *cs, const char *filename);
> -extern int git_configset_get_value(struct config_set *cs, const char *key, const char **value);
> extern const struct string_list *git_configset_get_value_multi(struct config_set *cs, const char *key);
> extern void git_configset_clear(struct config_set *cs);
> +
> +/*
> + * These functions return 1 if not found, and 0 if found, leaving the found
> + * value in the 'dest' pointer.
> + */
> +extern int git_configset_get_value(struct config_set *cs, const char *key, const char **dest);
> extern int git_configset_get_string_const(struct config_set *cs, const char *key, const char **dest);
> extern int git_configset_get_string(struct config_set *cs, const char *key, char **dest);
> extern int git_configset_get_int(struct config_set *cs, const char *key, int *dest);
next prev parent reply other threads:[~2018-08-06 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 14:33 [PATCH v5 0/2] sideband: highlight keywords in remote sideband output Han-Wen Nienhuys
2018-08-06 14:33 ` [PATCH v5 1/2] config: document git config getter return value Han-Wen Nienhuys
2018-08-06 16:32 ` Junio C Hamano [this message]
2018-08-06 16:40 ` Han-Wen Nienhuys
2018-08-06 14:33 ` [PATCH v5 2/2] sideband: highlight keywords in remote sideband output Han-Wen Nienhuys
2018-08-06 17:21 ` Junio C Hamano
2018-08-06 17:42 ` Han-Wen Nienhuys
2018-08-06 17:51 ` Junio C Hamano
2018-08-06 17:46 ` Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsh3rpial.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=jrn@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).