From: Junio C Hamano <gitster@pobox.com>
To: Christian Weiske <cweiske@cweiske.de>
Cc: git@vger.kernel.org
Subject: Re: Bug: git add --patch does not honor "diff.noprefix"
Date: Sun, 09 Dec 2018 10:30:42 +0900 [thread overview]
Message-ID: <xmqqsgz75vwd.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <c165fc5f-c452-fb2e-8ac3-d2afb12948bc@cweiske.de> (Christian Weiske's message of "Thu, 6 Dec 2018 11:34:43 +0100")
Christian Weiske <cweiske@cweiske.de> writes:
> When running "git add -p" on git version 2.19.2 and "diff.noprefix" set
> to true, it still shows the "a/" and "b/" prefixes.
>
> This issue has been reported in 2016 already[1], but is still there in
> 2.19.2.
It is very likely because it is a non-issue.
The reason why prefixes are customizable is to match the convention
used to show your patch to others, but the patch to be immediately
consumed within an "add -i/-p" session is viewed only by the user,
so it is much much lower priority to change the code. I guess the
reason why no such change was made is because nobody felt it worth
the trouble to change the code to use a non-standard prefix when
producing the patch to be shown, and then also change the code to
accept a non-standard prefix when using the chosen patch to be
applied.
prev parent reply other threads:[~2018-12-09 1:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 10:34 Bug: git add --patch does not honor "diff.noprefix" Christian Weiske
2018-12-09 1:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsgz75vwd.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=cweiske@cweiske.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).