From: Junio C Hamano <email@example.com>
To: "Robert P. J. Day" <firstname.lastname@example.org>
Cc: Jeff King <email@example.com>, Git Mailing list <firstname.lastname@example.org>
Subject: Re: is it "git gc --prune=now" or "git gc --prune=all"?
Date: Mon, 11 Mar 2019 11:18:01 +0900 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <alpine.LFD.firstname.lastname@example.org> (Robert P. J. Day's message of "Sat, 9 Mar 2019 13:13:41 -0500 (EST)")
"Robert P. J. Day" <email@example.com> writes:
> On Wed, 6 Mar 2019, Junio C Hamano wrote:
>> Jeff King <firstname.lastname@example.org> writes:
>> > ... I do think the documentation should recommend "now". Possibly
>> > builtin/gc.c should be smarter about recognizing "all" in the
>> > conditional you quoted, too, though I don't know that it's all
>> > that important (especially if we tweak the documentation).
>> Yup, as the placeholder for the value is labeled as "<date>", "now"
>> would be the one we should be encouraging.
> i can submit an obviously trivial patch for that
You already did to turn --prune=all into --prune=now in the doc, I
Do we encourage 'false' where we should encourage 'never'? I see we
do not even mention the negative form in git-gc manpage, and I think
it is a good thing, especially because --prune=<date> is listed just
next to --no-prune, which is even more explicit.
prev parent reply other threads:[~2019-03-11 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 8:26 is it "git gc --prune=now" or "git gc --prune=all"? Robert P. J. Day
2019-03-05 5:03 ` Jeff King
2019-03-06 0:08 ` Junio C Hamano
2019-03-09 18:13 ` Robert P. J. Day
2019-03-11 2:18 ` Junio C Hamano [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).