git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Masaya Suzuki <masayasuzuki@google.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] credential: add nocache option to the credentials API
Date: Mon, 26 Aug 2019 09:27:56 -0700	[thread overview]
Message-ID: <xmqqsgpnj3hv.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190722210037.GA31664@sigill.intra.peff.net> (Jeff King's message of "Mon, 22 Jul 2019 17:00:38 -0400")

Jeff King <peff@peff.net> writes:

> I was thinking that Git itself could treat "ttl=0" specially, the same
> as your nocache, and avoid passing it along to any helpers during the
> approve stage. That would make it exactly equivalent to your patch
> (modulo the name change).
> ...
> And as you noted above, if we don't suppress the helper calls inside
> Git, then every matching storage helper needs to learn about "nocache"
> (or "ttl") before it will do any good.

I was waiting for this discussion to settle and then the discussion
seems to have petered out.  Any interest to following the "ttl with
special casing value 0 as 'nocache'" idea thru from either two of
you, or should I take the patch as is in the meantime?

Thanks.

  reply	other threads:[~2019-08-26 16:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-07  5:51 [PATCH] credential: add nocache option to the credentials API Masaya Suzuki
2019-07-09 12:56 ` Jeff King
2019-07-22 17:30   ` Masaya Suzuki
2019-07-22 21:00     ` Jeff King
2019-08-26 16:27       ` Junio C Hamano [this message]
2019-09-15 21:50         ` Masaya Suzuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsgpnj3hv.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=masayasuzuki@google.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).