From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id A35501F463 for ; Mon, 30 Dec 2019 17:02:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727300AbfL3RCY (ORCPT ); Mon, 30 Dec 2019 12:02:24 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:53884 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727123AbfL3RCY (ORCPT ); Mon, 30 Dec 2019 12:02:24 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 10FF230979; Mon, 30 Dec 2019 12:02:22 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=xNOpIuJeIDDS7DnkKTaZ0gFdF8E=; b=rgAgy1 Eec9OWgBrOGYhl1Zgjv4KPr2RkLarOcZlVft0ZlrStns5nfzhGrw/9TZefau8coD qc+PxV1FRb3JgCxh48uQ/5WZ20GEu07eu6QZCHLmKjs4WZ3T6SiOFTaWCQgl8Aog k36G2WgoSCi4ywU63wWCv0iVW2wLweQZxSLOg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=fEkUCyXn+7KdW/GvYqnkuWMldlwXhsD7 YQQmatdMztqTDDX1+3yA9094FoLxocAKiuMkmJVRGpbN80BxhXXFGiopOspG1Hc5 1GZkZT5joiTcluMoULWXPLmYX+IopiOylL4hdbl1Tyk5l8GIz+a8nwjerD9MDBgM oWxf9xoy33g= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id EC90F30978; Mon, 30 Dec 2019 12:02:21 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 48A1E30977; Mon, 30 Dec 2019 12:02:21 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: Derrick Stolee , Garima Singh via GitGitGadget , git@vger.kernel.org, szeder.dev@gmail.com, jonathantanmy@google.com, jeffhost@microsoft.com, me@ttaylorr.com Subject: Re: [PATCH 0/9] [RFC] Changed Paths Bloom Filters References: <20191222093036.GA3449072@coredump.intra.peff.net> <20191229062414.GC220034@coredump.intra.peff.net> Date: Mon, 30 Dec 2019 09:02:19 -0800 In-Reply-To: <20191229062414.GC220034@coredump.intra.peff.net> (Jeff King's message of "Sun, 29 Dec 2019 01:24:14 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 24BC0974-2B26-11EA-96B9-D1361DBA3BAF-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > This is holding internal state in diff_options, but the same > diff_options is often used for multiple diffs (e.g., "git log --raw" > would use the same rev_info.diffopt over and over again). > > So it would need to be cleared between diffs. There's a similar feature > in the "has_changes" flag, though it looks like it is cleared manually > by callers. Yuck. Do you mean we want reset_per_invocation_part_of_diff_options() helper or something? > I actually wonder if this could be rolled into the has_changes and > diff_can_quit_early() feature. This really just a generalization of that > feature (which is like setting max_changes to "1"). Yeah, I wondered about the same thing, after seeing the impressive numbers ;-)