git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jörn Engel" <joern@purestorage.com>
Cc: git@vger.kernel.org
Subject: Re: new file mode 160000
Date: Tue, 10 Mar 2020 12:46:06 -0700	[thread overview]
Message-ID: <xmqqsgighu2p.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200310184111.GD1443@cork> ("Jörn Engel"'s message of "Tue, 10 Mar 2020 11:41:11 -0700")

Jörn Engel <joern@purestorage.com> writes:

> Something weird happened to us and I have no idea how to reproduce it.
> A developer managed to create a git commit with the following content:
>
> diff --git a/foo b/foo
> new file mode 160000
> index 000000000000..b7e7816c1266
> --- /dev/null
> +++ b/foo
> @@ -0,0 +1 @@
> +one line of content
>
> File name and content obfuscated, the rest is verbatim from the git
> commit.
>
> Now, file mode 160000 doesn't make sense to me.

These are gitlinks, that are used to implement submodules.  I cannot
tell if this is an expected behaviour and there is nothing to worry
about, or you found a corner case bug, without looking at what the
"one line of content" says, but if it says "Subproject commit "
followed by 40-hex object name, then that is a perfectly normal
behaviour.

After doing these:

	git init bar
	cd bar
	git init foo
	cd foo ;# in bar/foo
	git commit --allow-empty -m initial
	cd .. ;# back in bar
	git add foo
	git commit -m add
	git show

anybody who has a working Git would see the "diff --git" that shows 160000
you showed above.



  parent reply	other threads:[~2020-03-10 19:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 18:41 new file mode 160000 Jörn Engel
2020-03-10 19:10 ` Andreas Schwab
2020-03-10 19:47   ` Junio C Hamano
2020-03-10 20:09     ` Andreas Schwab
2020-03-11 18:35       ` Junio C Hamano
2020-03-10 19:37 ` Bryan Turner
2020-03-10 19:46 ` Junio C Hamano [this message]
2020-03-10 19:57   ` Jörn Engel
2020-03-10 22:22     ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsgighu2p.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=joern@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).