git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
	git@vger.kernel.org, hji@dyntopia.com
Subject: Re: [PATCH] t: avoid alternation (not POSIX) in grep's BRE
Date: Thu, 28 May 2020 12:20:49 -0700	[thread overview]
Message-ID: <xmqqsgfj3lym.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200528165245.GA1223396@coredump.intra.peff.net> (Jeff King's message of "Thu, 28 May 2020 12:52:45 -0400")

Jeff King <peff@peff.net> writes:

> But I haven't really found a use for "Fixes" in machine-readable format.
> I don't _mind_ people doing it if they do have a use (and I'd even
> consider doing it myself if I were shown that it was useful). In the
> meantime, I don't know if we want to state a project preference against
> it.

I've seen "Fixes: bug number" in projects that maintain bug
databases and automatically updates the status of the named bug when
a commit with such a footer hits certain integration branches; the
utility of such a usecase would be fairly obvious.

But "Fixes: <commit>" makes me nervous.  One reason is because a
commit very often introduces multiple bugs (or no bugs at all), so
which one (or more) of the bug is corrected cannot be read from such
a footer that _only_ blames a particular commit.

	Side note: also "fixes:" footer would cast a claim made when
	a commit was created in stone---which may later turn out to
	be false.  But the issue is not unique to "Fixes: <commit>";
	"Fixes: <bugid>" suffers exactly from the same problem.

An interesting aspect of "Fixes: <commit>" is that we can use it to
easily see who is the buggiest by dividing number of buggy commit by
number of total commits per author ;-)

I'd rather not to see people adding random footers whose utility is
dubious, but for this particular one, I am not against it strongly
enough to be tempted to declare an immediate ban.

  reply	other threads:[~2020-05-28 19:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  8:37 [PATCH] t: avoid alternation (not POSIX) in grep's BRE Carlo Marcelo Arenas Belón
2020-05-28 15:20 ` Junio C Hamano
2020-05-28 15:43   ` Jeff King
2020-05-28 15:51     ` Junio C Hamano
2020-05-28 16:52       ` Jeff King
2020-05-28 19:20         ` Junio C Hamano [this message]
2020-05-28 20:35           ` Jeff King
2020-05-29  3:18             ` digging into historical commit references Jeff King
2020-05-29  3:39 ` [PATCH] t: avoid alternation (not POSIX) in grep's BRE Torsten Bögershausen
2020-05-29  8:20 ` [PATCH v2] " Carlo Marcelo Arenas Belón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsgfj3lym.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hji@dyntopia.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).