From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id B8F721F66E for ; Tue, 18 Aug 2020 19:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbgHRT1H (ORCPT ); Tue, 18 Aug 2020 15:27:07 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:60374 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726585AbgHRT1G (ORCPT ); Tue, 18 Aug 2020 15:27:06 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 5EBE08E68D; Tue, 18 Aug 2020 15:27:02 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=7JrzoN3IagqD E8d7k/UJS+lowXY=; b=tzs5ak+jaJhydYUJINehmPQdNR60SLzpmQiDnnRB3blV 9PVoI9YtTGbT5FQ1/2waBmLKtDvL7vX9yu/OWEIwvpqAcRPzj6Vzo0fgZKZqssY2 0uN57I4xlK9sWPFTwph6bbE5HNIJaI7u0dMyF78c5n+yeb01ujb5mEj1DRdhg1Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=GlE6h5 mkClkmAyw76/jWdtGasZtEVml3Zzq7f6xrY9re9mDsa5yX3W5eKD/djAf5B1Yv27 O3nmPn+TPhEitkqXXbM3kgOqDZBcCbRZisqnPttWDdYrOQB/sJ5mgFx7cSiuyPHF KVAcaKBBaZfZIbsZy1TsEEiACzQjhg/3v/8O8= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 560958E68C; Tue, 18 Aug 2020 15:27:02 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id D25998E68B; Tue, 18 Aug 2020 15:27:01 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Elijah Newren via GitGitGadget" Cc: git@vger.kernel.org, Matheus Tavares , Eric Sunshine , =?utf-8?Q?Ren=C3=A9?= Scharfe , Elijah Newren Subject: Re: [PATCH v3 0/3] Extend and add a little more generalization to the mem_pool API References: Date: Tue, 18 Aug 2020 12:27:00 -0700 In-Reply-To: (Elijah Newren via GitGitGadget's message of "Sat, 15 Aug 2020 17:37:54 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: CA94DEAC-E188-11EA-8760-2F5D23BA3BAF-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Elijah Newren via GitGitGadget" writes: > In my new merge algorithm, I made use of the mem_pool API in a few > places...but I also needed to add a few more functions and also needed = to > make the API a bit more general. > > Changes since v2: > > * Remove 'x' from mem_pool_xstr[n]?dup() names and remove check for NU= LL > since mem_pool_alloc() already handles that (via xmalloc), as sugges= ted > by Ren=C3=A9 > * Rewrite mem_pool_strndup() to not rely on strnlen(), since that may = be > too new from some systems (comes from POSIX 2008 ). Also pointed out= by > Ren=C3=A9 Thanks; will queue.