From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 68B621F66F for ; Mon, 2 Nov 2020 18:34:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbgKBSeG (ORCPT ); Mon, 2 Nov 2020 13:34:06 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:61364 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbgKBSeF (ORCPT ); Mon, 2 Nov 2020 13:34:05 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 8A579A05A0; Mon, 2 Nov 2020 13:34:02 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=sasl; bh=IV6fD7WsWJct5naTA/IdDknf3lQ=; b=KBlQZNqOZbAsj1CX4w+6 aQYkheHgizzYuuwOLIOPmZAyUY7hJBCRo7GvzO2Aul7bQuR/xVoVtqEK98K0iB11 uyWJtjdmHK6sH9pOL04DdSFAl1ZqPGsXI1vZ0oW6wSTpBqyTPbccZXib7OOLyZ3O SXRxfS5uH8GRLCSp2IBJMcc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; q=dns; s=sasl; b=IUTIHwtrgmW4Yf+OjB+GB3WiuyzYGy5CA93BaVieh3Lwrj afe6zMBNwIuWtRO+KM7pPhNjxHQAVU8rnulwu9z1lyinwgqyrWRQLf16p7TJIt7f zoTziNQvEvKmTsTFcozjPGPr+SixWjOVmULcpnEWPmfVcbPFLbDBGBEF1bVMA= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 801ECA059F; Mon, 2 Nov 2020 13:34:02 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id D9051A059D; Mon, 2 Nov 2020 13:34:01 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Johannes Schindelin Cc: git@vger.kernel.org, Jonathan Tan Subject: Re: jc/sequencer-stopped-sha-simplify, was Re: What's cooking in git.git (Oct 2020, #04; Tue, 27) References: Date: Mon, 02 Nov 2020 10:34:00 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: FA90EB0E-1D39-11EB-88A4-D152C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Johannes Schindelin writes: > Hi Junio, > > On Tue, 27 Oct 2020, Junio C Hamano wrote: > >> * jc/sequencer-stopped-sha-simplify (2020-10-21) 1 commit >> - sequencer: tolerate abbreviated stopped-sha file >> >> Recently the format of an internal state file "rebase -i" uses has >> been tightened up for consistency, which would hurt those who start >> "rebase -i" with old git and then continue with new git. Loosen >> the reader side a bit (which we may want to tighten again in a year >> or so). >> >> Is this a real issue, or just a theoretical one? >> cf. > > We had a similar situation when we decided to fix the incorrect quoting in > the `author-script` file, and we decided that we have to be careful: > https://lore.kernel.org/git/nycvar.QRO.7.76.6.1807271415410.10478@tvgsbejvaqbjf.bet/ > > In light of that, I think we should go with Jonathan's patch for a couple > of versions before tightening the reader side again. I do not mind taking the approach as a prudent and careful thing, but I want the question answered regardless, as I know Jonathan is in a good position to tell if this is just a theoretical issue than I am, and depending on the answer, we may rethink the approach of trying to be overly careful. Thanks.